You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/24 07:08:11 UTC

[GitHub] [incubator-superset] ktmud commented on pull request #11415: style: fix labels vertical align

ktmud commented on pull request #11415:
URL: https://github.com/apache/incubator-superset/pull/11415#issuecomment-715833612


   Just for the record, this PR also fixes the alignment of the datasource menu trigger on Explore page.
   
   ### Before
   
   <img src="https://user-images.githubusercontent.com/335541/97070201-5bd11a80-158b-11eb-9222-ed3bd298a67e.png" width="300">
   
   (misaligned by #11400 )
   
   ### After
   
   <img src="https://user-images.githubusercontent.com/335541/97070340-67711100-158c-11eb-8ef4-741036428ef3.png" width="300">
   
   ### BTW...
   
   Can we also add some space between the pill and the database name?
   
   <img src="https://user-images.githubusercontent.com/335541/97070315-3690dc00-158c-11eb-8815-a2e151f2e567.png" width="300">
   
   This label on the Edit Datasource modal also doesn't seem to need some adjustment
   
   <img src="https://user-images.githubusercontent.com/335541/97070383-c20a6d00-158c-11eb-82d3-fe2c5ea2d671.png" width="500">
   
   <img src="https://user-images.githubusercontent.com/335541/97070409-ef571b00-158c-11eb-8e4f-60772bdb8d98.png" width="500">
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org