You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Dandandan (via GitHub)" <gi...@apache.org> on 2023/06/26 21:08:44 UTC
[GitHub] [arrow-datafusion] Dandandan opened a new pull request, #6772: Use projection
Dandandan opened a new pull request, #6772:
URL: https://github.com/apache/arrow-datafusion/pull/6772
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on pull request #6772: Add/Use projection in hashjoinexec
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on PR #6772:
URL: https://github.com/apache/arrow-datafusion/pull/6772#issuecomment-1627213157
I think output order, equivalence properties, etc. should also be refactored here. Nice PR btw. Do you think that there will be a performance increase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #6772: Add/Use projection in hashjoinexec
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6772:
URL: https://github.com/apache/arrow-datafusion/pull/6772#issuecomment-1627313526
Yes this also involves changing the projection pushdown, which also should remove the then unnecessary `ProjectionExec` in most cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add/Use projection in hashjoinexec [arrow-datafusion]
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan closed pull request #6772: Add/Use projection in hashjoinexec
URL: https://github.com/apache/arrow-datafusion/pull/6772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #6772: Add/Use projection in hashjoinexec
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6772:
URL: https://github.com/apache/arrow-datafusion/pull/6772#issuecomment-1627244325
> I think output order, equivalence properties, etc. should also be refactored here. Nice PR btw. Do you think that there will be a performance increase?
Yeah need to revisit this PR a bit later (or please continue on it if you like).
I expect a (modest) performance increase as we can skip things like `take` and `coalescebatches` on the arrays that are not included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] Dandandan commented on pull request #6772: Add/Use projection in hashjoinexec
Posted by "Dandandan (via GitHub)" <gi...@apache.org>.
Dandandan commented on PR #6772:
URL: https://github.com/apache/arrow-datafusion/pull/6772#issuecomment-1627253762
The performance increase depends a bit on how many / what kind of columns are necessary in the output projection. For example, if we can skip `take` on some string-kernels and the benefit will be higher than in other cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] metesynnada commented on pull request #6772: Add/Use projection in hashjoinexec
Posted by "metesynnada (via GitHub)" <gi...@apache.org>.
metesynnada commented on PR #6772:
URL: https://github.com/apache/arrow-datafusion/pull/6772#issuecomment-1627292528
> The performance increase depends a bit on how many / what kind of columns are necessary in the output projection. For example, if we can skip `take` on some string arrays then the benefit will be higher than in other cases.
Yeah, you are quite right, it will prevent unnecessary `compute::take` s in some cases. Do you also plan to change the `PushDownProjection` rule?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org