[GitHub] [airflow] mik-laj commented on a change in pull request #6050: [AIRFLOW-5434][DONT-MERGE] Use hook to provide credentials in GKEPodOperator

[GitBox <gi...@apache.org>]

mik-laj commented on a change in pull request #6050: [AIRFLOW-5434][DONT-MERGE] Use hook to provide credentials in GKEPodOperator
URL: https://github.com/apache/airflow/pull/6050#discussion_r322000073
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_api_base_hook.py
 ##########
 @@ -283,32 +284,50 @@ def inner_wrapper(self: GoogleCloudBaseHook, *args, **kwargs) -> RT:
     @staticmethod
     def provide_gcp_credential_file(func: Callable[..., RT]) -> Callable[..., RT]:
         """
-        Function decorator that provides a ``GOOGLE_APPLICATION_CREDENTIALS``
-        environment variable, pointing to file path of a JSON file of service
-        account key.
+        Function decorator that provides a GCP credentials for application supporting Application
 
 Review comment:
   i think, we can use https://pypi.org/project/contextdecorator/ here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services