You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2017/06/05 01:39:31 UTC
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Remove 'start-local.sh' scr...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/4074
[FLINK-6488] [scripts] Remove 'start-local.sh' script
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [ ] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-6488
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4074.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4074
----
commit be3fffc8adcebcfc24f0c50de2abcf69354be8dd
Author: zhangminglei <zm...@163.com>
Date: 2017-06-05T01:38:04Z
[FLINK-6488] [scripts] Remove 'start-local.sh' script
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol Thanks a bunch for your review. I have updated the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4074
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
Sorry, I dont know what you exactly mean. I just modified the scripts. Why did I modify the permissions of this file ? I really need your help. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4074
Under the "Files changed" tab on GitHub you can see this ` 100755 → 100644 ` next to the `start-local.sh` script, which means that you removed (somehow) the execute permission from this file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' s...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4074
You are changing the permissions for the `start-local.sh` script.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r121618561
--- Diff: flink-dist/src/main/flink-bin/bin/stop-local.sh ---
@@ -17,11 +17,12 @@
# limitations under the License.
################################################################################
+echo "Warning: this file is deprecated and will be remove in the future"
--- End diff --
We can be specific and say removed in 1.5, also missing period at the end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4074
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Remove 'start-local.sh' script
Posted by greghogan <gi...@git.apache.org>.
Github user greghogan commented on the issue:
https://github.com/apache/flink/pull/4074
@zhangminglei, the ticket also lists having `start-local.sh` call `start-cluster.sh` rather than starting a JobManager in local mode.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r122940544
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -472,7 +472,7 @@ class JobManager(
taskManagerGateway match {
case x: ActorTaskManagerGateway =>
handleTaskManagerTerminated(x.getActorGateway().actor(), instance.getId)
- case _ => log.debug(s"Cannot remove reosurce ${resourceID}, because there is " +
+ case _ => log.debug(s"Cannot remove resource ${resourceID}, because there is " +
--- End diff --
I think I have finished that. Please check it. :XD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol It seems weird why this stuff happened. I have updated the code though. It looks good now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r121618627
--- Diff: flink-dist/src/main/flink-bin/bin/stop-local.sh ---
@@ -17,11 +17,12 @@
# limitations under the License.
################################################################################
+echo "Warning: this file is deprecated and will be remove in the future"
--- End diff --
typo: remove -> removeda
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' s...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol Ooooops. I was wrong. I also did the same thing in ```stop-local.sh```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4074
+1 to merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' s...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@greghogan Thanks. I just forgot update the title, it is not remove but deprecated instead. And I would suggest you can take a look at this jira https://issues.apache.org/jira/browse/FLINK-6488.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r121618430
--- Diff: flink-dist/src/main/flink-bin/bin/start-local.sh ---
@@ -19,10 +19,12 @@
STREAMING_MODE=$1
+echo "Warning: this file is deprecated and will be remove in the future"
+
bin=`dirname "$0"`
bin=`cd "$bin"; pwd`
. "$bin"/config.sh
# local mode, only bring up job manager. The job manager will start an internal task manager
--- End diff --
comment can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r121618454
--- Diff: flink-dist/src/main/flink-bin/bin/stop-local.sh ---
@@ -17,11 +17,12 @@
# limitations under the License.
################################################################################
+echo "Warning: this file is deprecated and will be remove in the future"
bin=`dirname "$0"`
bin=`cd "$bin"; pwd`
. "$bin"/config.sh
# stop local job manager (has an internal task manager)
--- End diff --
comment can be removed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' s...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4074
Greg is correct, the start-local.sh script should still call the start-cluster.sh script.
Here's what i wrote in the JIRA:
> We will change start-local.sh to a) print a deprecation warning and b) call start-cluster.sh.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r121618612
--- Diff: flink-dist/src/main/flink-bin/bin/start-local.sh ---
@@ -19,10 +19,12 @@
STREAMING_MODE=$1
+echo "Warning: this file is deprecated and will be remove in the future"
--- End diff --
typo: remove -> removeda
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
@zentol OMG. I see now. OKay, I will take a look. Thanks a bunch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
It seems that I didnt do anything relevant to the file permissions. Does not make sense.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r122934898
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -472,7 +472,7 @@ class JobManager(
taskManagerGateway match {
case x: ActorTaskManagerGateway =>
handleTaskManagerTerminated(x.getActorGateway().actor(), instance.getId)
- case _ => log.debug(s"Cannot remove reosurce ${resourceID}, because there is " +
+ case _ => log.debug(s"Cannot remove resource ${resourceID}, because there is " +
--- End diff --
OKay. I'd love to do this. I will push again soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r121618547
--- Diff: flink-dist/src/main/flink-bin/bin/start-local.sh ---
@@ -19,10 +19,12 @@
STREAMING_MODE=$1
+echo "Warning: this file is deprecated and will be remove in the future"
--- End diff --
We can be specific and say removed in 1.5, also missing period at the end.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/4074
Also say thanks to you ~ :XD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4074: [FLINK-6488] [scripts] Mark deprecated 'start-loca...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4074#discussion_r122926445
--- Diff: flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala ---
@@ -472,7 +472,7 @@ class JobManager(
taskManagerGateway match {
case x: ActorTaskManagerGateway =>
handleTaskManagerTerminated(x.getActorGateway().actor(), instance.getId)
- case _ => log.debug(s"Cannot remove reosurce ${resourceID}, because there is " +
+ case _ => log.debug(s"Cannot remove resource ${resourceID}, because there is " +
--- End diff --
Can you move this change into a separate commit?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4074: [FLINK-6488] [scripts] Mark deprecated 'start-local.sh' a...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4074
you're still modifying the file permissions of the `start-local.sh` file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---