You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by wangjiaochun <gi...@git.apache.org> on 2017/06/30 02:08:42 UTC

[GitHub] spark pull request #18475: [SPARK][Tests] assert messager not right

GitHub user wangjiaochun opened a pull request:

    https://github.com/apache/spark/pull/18475

    [SPARK][Tests] assert messager not right

    Signed-off-by: 10087686 <wa...@zte.com.cn>
    
    ## What changes were proposed in this pull request?
    Modify the assert message;
    (Please fill in changes proposed in this fix)
    
    ## How was this patch tested?
    
    (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
    (If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
    
    Please review http://spark.apache.org/contributing.html before opening a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wangjiaochun/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/18475.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #18475
    
----
commit 9491b11207b4d9b922c700fa3eb3eea9160c1180
Author: 10087686 <wa...@zte.com.cn>
Date:   2017-06-30T02:01:56Z

    assert messager not right
    Signed-off-by: 10087686 <wa...@zte.com.cn>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18475: [SPARK][Tests] assert messager not right

Posted by cloud-fan <gi...@git.apache.org>.
Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/18475
  
    This is just a typo and is so minor...  maybe you can just include it in other related PRs of yours


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18475: [SPARK][Tests] assert messager not right

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/18475
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #18475: [SPARK][Tests] assert messager not right

Posted by wangjiaochun <gi...@git.apache.org>.
Github user wangjiaochun closed the pull request at:

    https://github.com/apache/spark/pull/18475


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18475: [SPARK][Tests] assert messager not right

Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/18475
  
    Sounds we should close if it is not the very first contribution of the author.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #18475: [SPARK][Tests] assert messager not right

Posted by wangjiaochun <gi...@git.apache.org>.
Github user wangjiaochun commented on the issue:

    https://github.com/apache/spark/pull/18475
  
    ok!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org