You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/02/18 08:32:21 UTC

[GitHub] mgaido91 commented on a change in pull request #23802: [SPARK-26893][SQL] Allow partition pruning with subquery filters on file source

mgaido91 commented on a change in pull request #23802: [SPARK-26893][SQL] Allow partition pruning with subquery filters on file source
URL: https://github.com/apache/spark/pull/23802#discussion_r257592808
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
 ##########
 @@ -185,6 +185,14 @@ case class FileSourceScanExec(
     ret
   }
 
+  @transient private lazy val selectedPartitionsCount =
+    if (partitionFilters.exists(f =>
+      SubqueryExpression.hasSubquery(f) || ExecSubqueryExpression.hasSubquery(f))) {
 
 Review comment:
   why do we need to check both?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org