[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #6726: feat: Add graphviz display format for execution plan.

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #6726:
URL: https://github.com/apache/arrow-datafusion/pull/6726#discussion_r1235693855


##########
Cargo.toml:
##########
@@ -51,6 +51,9 @@ arrow-buffer = { version = "41.0.0", default-features = false }
 arrow-schema = { version = "41.0.0", default-features = false }
 arrow-array = { version = "41.0.0", default-features = false, features = ["chrono-tz"] }
 parquet = { version = "41.0.0", features = ["arrow", "async", "object_store"] }
+graphviz-rust = "0.6.2"

Review Comment:
   These crates appear to be relatively new and from a single author -- 
   
   https://crates.io/crates/graphviz-rust
   https://crates.io/crates/dot-structures
   https://crates.io/crates/dot-generator
   
   Could you comment on how much value they add rather than implementing the relevant portions within datafusion (graphviz is not a complicated format and doesn't typically need a library to create, in my experience)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org