[GitHub] [superset] pkdotson commented on a change in pull request #18953: feat: allow uploads in crud view

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #18953:
URL: https://github.com/apache/superset/pull/18953#discussion_r816398918



##########
File path: superset-frontend/src/views/components/SubMenu.tsx
##########
@@ -231,6 +243,22 @@ const SubMenuComponent: React.FunctionComponent<SubMenuProps> = props => {
           })}
         </Menu>
         <div className={navRightStyle}>
+          <Menu mode="horizontal">
+            {props.dropDownLinks?.map((link, i) => (
+              <SubMenu key={i} title={link.label} icon={<Icons.TriangleDown />}>
+                {link.childs?.map(item => {
+                  if (typeof item === 'object') {

Review comment:
       This check is for typescript. It was complaining since child type could be string.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org