You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by ad...@apache.org on 2004/07/10 18:07:46 UTC

cvs commit: incubator-geronimo/modules/core/src/java/org/apache/geronimo/pool ThreadPool.java

adc         2004/07/10 09:07:46

  Modified:    modules/core/src/java/org/apache/geronimo/pool
                        ThreadPool.java
  Log:
  This should probably be setMinimumPoolSize.
  
  Since LinkedQueue is unbounded, there will never be more than one thread
  in the pool.
  
  Revision  Changes    Path
  1.3       +2 -3      incubator-geronimo/modules/core/src/java/org/apache/geronimo/pool/ThreadPool.java
  
  Index: ThreadPool.java
  ===================================================================
  RCS file: /home/cvs/incubator-geronimo/modules/core/src/java/org/apache/geronimo/pool/ThreadPool.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- ThreadPool.java	8 Jul 2004 22:07:54 -0000	1.2
  +++ ThreadPool.java	10 Jul 2004 16:07:46 -0000	1.3
  @@ -83,8 +83,7 @@
       public void doStart() throws WaitingException, Exception {
           PooledExecutor p = new PooledExecutor(new LinkedQueue(), poolSize);
           p.setKeepAliveTime(keepAliveTime);
  -        //I think this does nothing with a LinkedQueue present
  -        p.setMaximumPoolSize(poolSize);
  +        p.setMinimumPoolSize(poolSize);
           p.setThreadFactory(new ThreadFactory() {
               public Thread newThread(Runnable arg0) {
                   return new Thread(arg0, poolName + " " + getNextWorkerID());