You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "ywkaras (via GitHub)" <gi...@apache.org> on 2023/03/31 17:55:38 UTC

[GitHub] [trafficserver] ywkaras commented on a diff in pull request #9518: Add metrics testing to tls_tunnel Au test.

ywkaras commented on code in PR #9518:
URL: https://github.com/apache/trafficserver/pull/9518#discussion_r1154749479


##########
proxy/http/HttpTransact.cc:
##########
@@ -5723,9 +5723,13 @@ HttpTransact::initialize_state_variables_from_request(State *s, HTTPHdr *obsolet
     s->cache_info.action = CACHE_DO_NO_ACTION;
   }
 
+  bool do_increment_stat = (0 == s->method);
+
   s->method = incoming_request->method_get_wksidx();
 
-  if (s->method == HTTP_WKSIDX_GET) {
+  if (!do_increment_stat) {

Review Comment:
   Yes , it fixes the associated issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org