[GitHub] [iceberg] jackye1995 commented on a diff in pull request #6862: AWS: Changes to DynamoDb Catalog to support ACL on Namespace Entries

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #6862:
URL: https://github.com/apache/iceberg/pull/6862#discussion_r1172821813


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -294,6 +294,12 @@ public class AwsProperties implements Serializable {
 
   public static final String DYNAMODB_TABLE_NAME_DEFAULT = "iceberg";
 
+  public static final String DYNAMODB_V2_SCHEMA_DEFAULT_TABLE_NAME = "iceberg_v2";

Review Comment:
   nit: can we name it `DYNAMODB_TABLE_NAME_DEFAULT_V2`? And the default `iceberg_v2` is a bit confusing, can we use `iceberg_dynamodb_v2`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org