You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by HeartSaVioR <gi...@git.apache.org> on 2017/06/16 06:47:01 UTC
[GitHub] storm pull request #2162: STORM-2449 Ensure same key appears only once in St...
GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/2162
STORM-2449 Ensure same key appears only once in State iterator
* also don't expose TOMBSTONE keys
This implementation is for current Redis KV state.
I also have two State related pull requests #1970 and #1950 and I need to apply this patch to both of them. I'll update both after this patch is reviewed.
@arunmahadevan Please review and comment. Thanks in advance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HeartSaVioR/storm STORM-2449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2162.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2162
----
commit fdf63ce9a619ee24b52435e8f5945304912ad3ea
Author: Jungtaek Lim <ka...@gmail.com>
Date: 2017-06-16T06:39:45Z
STORM-2449 Ensure same key appears only once in State iterator
* also don't expose TOMBSTONE keys
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2162: STORM-2449 Ensure same key appears only once in State ite...
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2162
+1 LGTM
Before you apply this to #1970 and #1950, you can refactor the logic to make it re-usable across the different state implementations.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2162: STORM-2449 Ensure same key appears only once in St...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---