You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by yx...@apache.org on 2022/10/15 16:51:59 UTC

[shardingsphere] branch master updated: Refactor RuleDefinitionBackendHandler (#21595)

This is an automated email from the ASF dual-hosted git repository.

yx9o pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new faf90405790 Refactor RuleDefinitionBackendHandler (#21595)
faf90405790 is described below

commit faf904057902b49db19b0d807f2ed26b8bd2f945
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sun Oct 16 00:51:51 2022 +0800

    Refactor RuleDefinitionBackendHandler (#21595)
---
 .../handler/distsql/rdl/rule/RuleDefinitionBackendHandler.java       | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rdl/rule/RuleDefinitionBackendHandler.java b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rdl/rule/RuleDefinitionBackendHandler.java
index ce2732ca909..6819d1a1d2e 100644
--- a/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rdl/rule/RuleDefinitionBackendHandler.java
+++ b/proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/distsql/rdl/rule/RuleDefinitionBackendHandler.java
@@ -127,9 +127,6 @@ public final class RuleDefinitionBackendHandler<T extends RuleDefinitionStatemen
     }
     
     private boolean getRefreshStatus(final SQLStatement sqlStatement, final RuleConfiguration currentRuleConfig, final RuleDefinitionUpdater<?, ?> updater) {
-        if (updater instanceof RuleDefinitionDropUpdater) {
-            return ((RuleDefinitionDropUpdater) updater).hasAnyOneToBeDropped(sqlStatement, currentRuleConfig);
-        }
-        return true;
+        return !(updater instanceof RuleDefinitionDropUpdater) || ((RuleDefinitionDropUpdater) updater).hasAnyOneToBeDropped(sqlStatement, currentRuleConfig);
     }
 }