You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by zj...@apache.org on 2020/01/03 06:12:49 UTC

[zeppelin] branch master updated: [ZEPPELIN-4505] Save notebook on clear all paragraph output

This is an automated email from the ASF dual-hosted git repository.

zjffdu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/zeppelin.git


The following commit(s) were added to refs/heads/master by this push:
     new 6319e8b  [ZEPPELIN-4505] Save notebook on clear all paragraph output
6319e8b is described below

commit 6319e8b4eca2ea86e4747f583b6c38176176a5a1
Author: amakaur <am...@applovin.com>
AuthorDate: Mon Dec 23 18:03:23 2019 -0800

    [ZEPPELIN-4505] Save notebook on clear all paragraph output
    
    ### What is this PR for?
    Currently clear all paragraph output changes are only stored in memory. So, when zeppelin is restarted all of the output is displayed again on all of the notebooks.
    
    This PR saves the changes made to notebook and updates are reflected also on a restart. So there's no inconsistencies before and after a restart.
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-4505
    
    ### How should this be tested?
    - Create a notebook using Spark interpreter
    - Create any output
    - Trigger clear all paragraph output
    - Restart zeppelin and paragraph output will be erased as expected.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: amakaur <am...@applovin.com>
    
    Closes #3566 from amakaur/save_clear_output_to_external_storage and squashes the following commits:
    
    96d738200 [amakaur] Save notebook on clear all paragraph output
---
 .../src/main/java/org/apache/zeppelin/service/NotebookService.java       | 1 +
 1 file changed, 1 insertion(+)

diff --git a/zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java b/zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
index 05b2793..6a0af51 100644
--- a/zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
+++ b/zeppelin-server/src/main/java/org/apache/zeppelin/service/NotebookService.java
@@ -601,6 +601,7 @@ public class NotebookService {
     }
 
     note.clearAllParagraphOutput();
+    notebook.saveNote(note, context.getAutheInfo());
     callback.onSuccess(note, context);
   }