You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2014/11/27 16:34:54 UTC
Review Request 28517: Ambari Web: Lock navigation down while upgrade
is happening
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28517/
-----------------------------------------------------------
Review request for Ambari, Oleg Nechiporenko and Yusaku Sako.
Bugs: AMBARI-8467
https://issues.apache.org/jira/browse/AMBARI-8467
Repository: ambari
Description
-------
We need to lock down Ambari Web UI navigation while an upgrade is happening.
For Ambari Admins and Cluster Operators:
The user is treated as a read-only user so cluster operation controls are not shown, except for Upgrade related controls.
Cluster Read-only users:
Upgrade progress has no effect on read-only users; they can still navigate as before.
Diffs
-----
ambari-web/app/app.js 20ad4ac
ambari-web/app/controllers/application.js 87cc6b5
ambari-web/app/controllers/main/service/info/configs.js baa158f
ambari-web/app/controllers/wizard/step7_controller.js aecaa9c
ambari-web/app/mixins/common/userPref.js 78a2023
ambari-web/app/models/cluster_states.js 95c1444
ambari-web/app/router.js bf27c7d
ambari-web/app/routes/add_alert_definition_routes.js 0b30340
ambari-web/app/routes/add_service_routes.js d0421a8
ambari-web/app/routes/installer.js cab8c39
ambari-web/app/routes/main.js 53f4140
ambari-web/app/templates/application.hbs b931bb4
ambari-web/app/templates/common/configs/config_history_flow.hbs 0ad38aa
ambari-web/app/templates/common/configs/overriddenProperty.hbs fb438f3
ambari-web/app/templates/common/configs/service_config.hbs aeae30f
ambari-web/app/templates/common/configs/service_config_category.hbs 1ad4384
ambari-web/app/templates/common/configs/service_config_wizard.hbs 8bf7429
ambari-web/app/templates/common/configs/service_version_box.hbs 749cb1d
ambari-web/app/templates/main/admin/security.hbs 56c75f7
ambari-web/app/templates/main/host.hbs a1907c3
ambari-web/app/templates/main/host/bulk_operation_menu.hbs eec06e4
ambari-web/app/templates/main/host/details.hbs 75df5d3
ambari-web/app/templates/main/host/details/host_component.hbs 0ed8379
ambari-web/app/templates/main/host/stack_versions.hbs 853b7b6
ambari-web/app/templates/main/host/summary.hbs ec585eb
ambari-web/app/templates/main/mirroring/datasets.hbs e8925d9
ambari-web/app/templates/main/mirroring/jobs.hbs 9f8b845
ambari-web/app/templates/main/service/all_services_actions.hbs d17b519
ambari-web/app/templates/main/service/info/configs.hbs 267cd99
ambari-web/app/templates/main/service/info/summary.hbs bbf270f
ambari-web/app/templates/main/service/item.hbs a264f5f
ambari-web/app/utils/helper.js 27efd87
ambari-web/app/utils/host_progress_popup.js e089f57
ambari-web/app/views/common/table_view.js 207782a
ambari-web/app/views/main/menu.js cb708d1
ambari-web/app/views/main/mirroring/jobs_view.js 2e657f4
ambari-web/test/app_test.js 80b71a5
Diff: https://reviews.apache.org/r/28517/diff/
Testing
-------
4962 tests complete (8 seconds)
60 tests pending
Thanks,
Andrii Tkach
Re: Review Request 28517: Ambari Web: Lock navigation down while
upgrade is happening
Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28517/#review63233
-----------------------------------------------------------
Ship it!
Ship It!
- Oleg Nechiporenko
On Nov. 27, 2014, 3:34 p.m., Andrii Tkach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28517/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 3:34 p.m.)
>
>
> Review request for Ambari, Oleg Nechiporenko and Yusaku Sako.
>
>
> Bugs: AMBARI-8467
> https://issues.apache.org/jira/browse/AMBARI-8467
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We need to lock down Ambari Web UI navigation while an upgrade is happening.
> For Ambari Admins and Cluster Operators:
> The user is treated as a read-only user so cluster operation controls are not shown, except for Upgrade related controls.
> Cluster Read-only users:
> Upgrade progress has no effect on read-only users; they can still navigate as before.
>
>
> Diffs
> -----
>
> ambari-web/app/app.js 20ad4ac
> ambari-web/app/controllers/application.js 87cc6b5
> ambari-web/app/controllers/main/service/info/configs.js baa158f
> ambari-web/app/controllers/wizard/step7_controller.js aecaa9c
> ambari-web/app/mixins/common/userPref.js 78a2023
> ambari-web/app/models/cluster_states.js 95c1444
> ambari-web/app/router.js bf27c7d
> ambari-web/app/routes/add_alert_definition_routes.js 0b30340
> ambari-web/app/routes/add_service_routes.js d0421a8
> ambari-web/app/routes/installer.js cab8c39
> ambari-web/app/routes/main.js 53f4140
> ambari-web/app/templates/application.hbs b931bb4
> ambari-web/app/templates/common/configs/config_history_flow.hbs 0ad38aa
> ambari-web/app/templates/common/configs/overriddenProperty.hbs fb438f3
> ambari-web/app/templates/common/configs/service_config.hbs aeae30f
> ambari-web/app/templates/common/configs/service_config_category.hbs 1ad4384
> ambari-web/app/templates/common/configs/service_config_wizard.hbs 8bf7429
> ambari-web/app/templates/common/configs/service_version_box.hbs 749cb1d
> ambari-web/app/templates/main/admin/security.hbs 56c75f7
> ambari-web/app/templates/main/host.hbs a1907c3
> ambari-web/app/templates/main/host/bulk_operation_menu.hbs eec06e4
> ambari-web/app/templates/main/host/details.hbs 75df5d3
> ambari-web/app/templates/main/host/details/host_component.hbs 0ed8379
> ambari-web/app/templates/main/host/stack_versions.hbs 853b7b6
> ambari-web/app/templates/main/host/summary.hbs ec585eb
> ambari-web/app/templates/main/mirroring/datasets.hbs e8925d9
> ambari-web/app/templates/main/mirroring/jobs.hbs 9f8b845
> ambari-web/app/templates/main/service/all_services_actions.hbs d17b519
> ambari-web/app/templates/main/service/info/configs.hbs 267cd99
> ambari-web/app/templates/main/service/info/summary.hbs bbf270f
> ambari-web/app/templates/main/service/item.hbs a264f5f
> ambari-web/app/utils/helper.js 27efd87
> ambari-web/app/utils/host_progress_popup.js e089f57
> ambari-web/app/views/common/table_view.js 207782a
> ambari-web/app/views/main/menu.js cb708d1
> ambari-web/app/views/main/mirroring/jobs_view.js 2e657f4
> ambari-web/test/app_test.js 80b71a5
>
> Diff: https://reviews.apache.org/r/28517/diff/
>
>
> Testing
> -------
>
> 4962 tests complete (8 seconds)
> 60 tests pending
>
>
> Thanks,
>
> Andrii Tkach
>
>