You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/24 14:49:32 UTC

[GitHub] [spark] cloud-fan commented on a change in pull request #33824: [SPARK-36457][Docs] Review and fix issues in API docs

cloud-fan commented on a change in pull request #33824:
URL: https://github.com/apache/spark/pull/33824#discussion_r694926656



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryExecutionErrors.scala
##########
@@ -64,7 +64,7 @@ import org.apache.spark.util.CircularBuffer
  * This does not include exceptions thrown during the eager execution of commands, which are
  * grouped into [[QueryCompilationErrors]].
  */
-object QueryExecutionErrors {
+private[spark] object QueryExecutionErrors {

Review comment:
       shall we mark the entire `org.apache.spark.sql.errors` as private?
   
   See https://github.com/apache/spark/blob/master/project/SparkBuild.scala#L944-L973




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org