You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/31 16:27:09 UTC
[GitHub] [spark] grundprinzip opened a new pull request, #39330: [SPARK-41742][SPARK-41745][CONNECT] Cleanup previously failing doctest cases.
grundprinzip opened a new pull request, #39330:
URL: https://github.com/apache/spark/pull/39330
### What changes were proposed in this pull request?
Cleanup previously disabled test cases.
### Why are the changes needed?
Compatibility
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Reenabling doc tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on pull request #39330: [SPARK-41742][SPARK-41745][CONNECT] Cleanup previously failing doctest cases.
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on PR #39330:
URL: https://github.com/apache/spark/pull/39330#issuecomment-1368277381
Sure, I'll revise. Though I'd say that the "contribution" is rather checking that the previously disabled tests actually pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39330: [SPARK-41742][SPARK-41745][CONNECT] Reenable doc tests and add missing column alias to count()
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39330:
URL: https://github.com/apache/spark/pull/39330#issuecomment-1368394689
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39330: [SPARK-41742][SPARK-41745][CONNECT] Reenable doc tests and add missing column alias to count()
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39330: [SPARK-41742][SPARK-41745][CONNECT] Reenable doc tests and add missing column alias to count()
URL: https://github.com/apache/spark/pull/39330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org