You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "nicolazar (via GitHub)" <gi...@apache.org> on 2026/07/12 22:59:21 UTC

[PR] [elixir] Support complex types (Array/Map/Row) and nullability [fluss]

nicolazar opened a new pull request, #3636:
URL: https://github.com/apache/fluss/pull/3636

   
   <!--
   *Thank you very much for contributing to Fluss - we are happy that you want to help us improve Fluss. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GitHub issue](https://github.com/apache/fluss/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no issue.
   
     - Name the pull request in the format "[component] Title of the pull request", where *[component]* should be replaced by the name of the component being changed. Typically, this corresponds to the component label assigned to the issue (e.g., [kv], [log], [client], [flink], [rust], [python], [c++], [elixir]). Skip *[component]* if you are unsure about which is the best component.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes.
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
   
     - **Generative AI disclosure:** Indicate whether generative AI tools were used in authoring this PR. If yes, specify the tool below.
       - [ ] No generative AI tools used
       - [ ] Yes (please specify the tool below)
   
   **(The sections below can be removed for hotfixes or typos)**
   -->
   
   <!--
   Generated-by: [Tool Name and Version] following [the guidelines](https://github.com/apache/fluss/blob/main/AGENTS.md)
   -->
   
   ### Purpose
   
   This PR adds nested types and per-node nullability to the Elixir bindings, in both schema definitions and row values.
   
   <!-- Linking this pull request to the issue -->
   Linked issue: close #xxx
   
   <!-- What is the purpose of the change -->
   
   ### Brief change log
   
   - DataType gains recursive Array/Map/Row variants with recursive converters.
   - Nullability uses an additive {:not_null, dt} wrapper (types nullable by default, composable at any depth). The read path now preserves the flag, so primary-key columns read back as {:not_null, ...}.
   - Row value shapes: array -> list; map -> %{k => v}; row -> map keyed by field-name atom.
   
   <!-- Please describe the changes made in this pull request and explain how they address the issue -->
   
   ### Tests
   
   New unit tests (schema builder) and integration round-trips (schema and values); updated existing primary-key read assertions.
   
   <!-- List UT and IT cases to verify this change -->
   
   ### API and Format
   
   <!-- Does this change affect API or storage format -->
   
   ### Documentation
   
   <!-- Does this change introduce a new feature -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [elixir] Support complex types (Array/Map/Row) and nullability [fluss]

Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni commented on code in PR #3636:
URL: https://github.com/apache/fluss/pull/3636#discussion_r3579943949


##########
fluss-rust/bindings/elixir/test/integration/log_table_test.exs:
##########
@@ -166,6 +166,50 @@ defmodule Fluss.Integration.LogTableTest do
 
       cleanup_table(admin, table_name)
     end
+
+    test "round-trips array, map, and row values", %{conn: conn, admin: admin} do

Review Comment:
   Can we add a deeply-nested value (array<map<string,row>> or smth) and a nulls-at-depth case (null complex column + null array element/map value/row field)?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [elixir] Support complex types (Array/Map/Row) and nullability [fluss]

Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni merged PR #3636:
URL: https://github.com/apache/fluss/pull/3636


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org