You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/31 00:10:09 UTC

[GitHub] [skywalking] wu-sheng commented on pull request #7606: Fix dynamic configuration watch implementation current value not null when the config is deleted.

wu-sheng commented on pull request #7606:
URL: https://github.com/apache/skywalking/pull/7606#issuecomment-908792905


   @JaredTan95 when you do merging in the next time, please make the commit logs clean.
   
   ```
   Fix dynamic configuration watch implementation current value not null…
   … when the config is deleted. (#7606)
   
   * Fix dynamic configuration watch implementation current value not null when the config is deleted.
   
   * add changes.md
   
   * fix LoggingConfigWatcher watch.vale, and when value = null ,config not reset.
   
   * fix
   
   * fix style
   
   * Update oap-server/analyzer/agent-analyzer/src/main/java/org/apache/skywalking/oap/server/analyzer/provider/trace/UninstrumentedGatewaysConfig.java
   
   Co-authored-by: kezhenxu94 <ke...@apache.org>
   
   * use Strings.nullToEmpty
   
   Co-authored-by: 吴晟 Wu Sheng <wu...@foxmail.com>
   Co-authored-by: kezhenxu94 <ke...@apache.org>
   ```
   This is how it looks like now. Too many unnecessary things.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org