You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/01/18 01:08:44 UTC
DO NOT REPLY [Bug 48563] New: Dist build of trunk (Tomcat 7) fails
because extras dir is missing
https://issues.apache.org/bugzilla/show_bug.cgi?id=48563
Summary: Dist build of trunk (Tomcat 7) fails because extras
dir is missing
Product: Tomcat 7
Version: trunk
Platform: PC
OS/Version: All
Status: NEW
Severity: normal
Priority: P2
Component: Packaging
AssignedTo: dev@tomcat.apache.org
ReportedBy: jason.brittain@gmail.com
Created an attachment (id=24852)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=24852)
Patches dist.xml to first detect whether output/extras exists before trying to
copy its content.
Running:
$ ant -f dist.xml
in trunk fails right now with this output at the end:
release:
[copy] Copying 1 file to
/home/jasonb/svn/tomcat-trunk/output/release/v7.0.0-dev
[copy] Copying 1 file to
/home/jasonb/svn/tomcat-trunk/output/release/v7.0.0-dev
[copy] Copying 1 file to
/home/jasonb/svn/tomcat-trunk/output/release/v7.0.0-dev
[copy] Copying 1 file to
/home/jasonb/svn/tomcat-trunk/output/release/v7.0.0-dev/bin
[mkdir] Created dir:
/home/jasonb/svn/tomcat-trunk/output/release/v7.0.0-dev/bin/extras
BUILD FAILED
/home/jasonb/svn/tomcat-trunk/dist.xml:384:
/home/jasonb/svn/tomcat-trunk/output/extras not found.
It fails this way when I build in this order:
$ ant download
$ ant
$ ant -f dist.xml
I've attached a patch that fixes the problem.
Thanks.
--
Jason
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48563] Dist build of trunk (Tomcat 7) fails
because extras dir is missing
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48563
--- Comment #1 from Konstantin Kolinko <kn...@gmail.com> 2010-01-17 16:39:39 UTC ---
Neither TC 7 nor TC 6 build will fail if you build it in this order:
$ ant download
$ ant
$ ant -f extras.xml
$ ant -f dist.xml release
A release has to include extras, so I doubt that this deserves be fixed, but
others may have a different opinion on this.
At least we can add some "check-extras" target into the dependencies list of
"release" one, so to fail earlier.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48563] Dist build of trunk (Tomcat 7) fails
because extras dir is missing
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48563
--- Comment #2 from Jason Brittain <ja...@gmail.com> 2010-01-17 18:52:56 UTC ---
Whether extras are required to be built and distributed or not is subjective, I
agree. Here are the reasons I thought building extras was optional:
- The name "extras" makes it sound optional
- The fact that it is a separate, additional command to build extras
- Extras' build is split out into a separate Ant build file from that of the
rest of Tomcat
- Not everyone who is building their own Tomcat zip or tar.gz (ready to run)
will need or wants the extras
- The one thing that I could see that was preventing it from being optional was
this single directory check (now fixed)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48563] Dist build of trunk (Tomcat 7) fails
because extras dir is missing
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48563
--- Comment #3 from Mark Thomas <ma...@apache.org> 2010-01-28 13:05:59 GMT ---
I'd like to move to a single build.xml file and to clean up the various
dependencies between the build targets. Since the extras are part of the
release, even if they aren't part of the standard download, I don't see the
harm in moving to a single file.
The end goal is to be able to do:
svn co https://svn.apache.org/repos/asf/tomcat/trunk
ant release
and have a complete release locally with one or more targets to upload the
release files to the right places on ASF infrastructure. The other targets will
be retained, with the correct dependencies, for folks that want to run a
specific target for whatever reason.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 48563] Dist build of trunk (Tomcat 7) fails
because extras dir is missing
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48563
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |FIXED
--- Comment #4 from Mark Thomas <ma...@apache.org> 2010-02-02 05:19:09 GMT ---
build.xml, extras.xml and dist.xml have been merged and the dependencies fixed.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org