[jira] [Commented] (OAK-6138) Remove addObserver method from Scheduler API

["Andrei Dulceanu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OAK-6138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15994850#comment-15994850 ] 

Andrei Dulceanu commented on OAK-6138:
--------------------------------------

bq. Can we go further from here and make {{LockBasedSchedulerBuilder}} return (non) {{Observable}} instances of {{LockBasedScheduler}}...
Not sure if I got this right, but are you hinting towards two separate implementations, such as {{LockBasedScheduler}} and {{ObservableLockBasedScheduler}}, with the latter extending the former and adding only {{Observable}} behaviour?

> Remove addObserver method from Scheduler API
> --------------------------------------------
>
>                 Key: OAK-6138
>                 URL: https://issues.apache.org/jira/browse/OAK-6138
>             Project: Jackrabbit Oak
>          Issue Type: Task
>          Components: segment-tar
>            Reporter: Andrei Dulceanu
>            Assignee: Andrei Dulceanu
>            Priority: Minor
>             Fix For: 1.8, 1.7.3
>
>         Attachments: OAK-6138.patch
>
>
> We should remove the {{addObserver()}} method from the {{Scheduler}} interface and instead have {{LockBasedScheduler}} implement {{Observable}}(or not depending on the {{dispatchChanges}} flag in {{LockBasedSchedulerBuilder.build()}}. {{SegmentNodeStore.addObserver()}} would then instance of check the scheduler for {{Observable}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)