[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10164: feat: Added configuration to SQL Lab results "Explore" button

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #10164:
URL: https://github.com/apache/incubator-superset/pull/10164#discussion_r445824477



##########
File path: superset/models/core.py
##########
@@ -189,6 +189,12 @@ def allows_cost_estimate(self) -> bool:
             and cost_estimate_enabled
         )
 
+    @property
+    def allows_virtual_table_explore(self) -> bool:
+        extra = self.get_extra()
+
+        return bool(extra.get("virtual_table_explore_enabled", True))

Review comment:
       nit: I'd prefix this with `is` since it's a boolean




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org