You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "slievrly (via GitHub)" <gi...@apache.org> on 2026/10/18 04:44:52 UTC
[PR] fix: preserve bundled MIT licenses in 2.7.0 release artifacts [incubator-seata]
slievrly opened a new pull request, #8308:
URL: https://github.com/apache/incubator-seata/pull/8308
- [x] I have read the CONTRIBUTING.md guidelines.
- [x] I have registered the changes in the English and Chinese 2.7.0 changelogs.
### Ⅰ. Describe what this PR did
The 2.7.0 source/binary distributions declare bundled normalize.css 2.1.3 as MIT but omit its upstream copyright notice. The separately published ANTLR JAR contains MIT-derived MySQL parser classes while its generated LICENSE contains only Apache 2.0.
- Preserve the complete upstream normalize.css MIT license in `distribution/licenses/normalize.css-MIT`. The source root LICENSE points to `distribution/licenses/...`; binary LICENSE files point to their own `licenses/...` paths. The generated binary root LICENSE receives the namingserver entry through the existing aggregation step.
- Add a module-local `src/main/appended-resources/META-INF/LICENSE` for ANTLR. The inherited Maven remote-resources plugin appends the grammar's MIT terms to Apache 2.0 in both binary and sources JARs, without changing other modules.
- Exclude that third-party license text from ASF header checks. No NOTICE files or `LICENSE-server` changes are needed.
### Ⅱ. Does this pull request fix one issue?
Addresses two license omissions found during the 2.7.0 RC review. No linked issue.
### Ⅲ. Why don't you add test cases (unit test/integration test)?
This changes licensing resources only. Validation inspects the generated artifacts and assembly paths instead of application unit tests.
### Ⅳ. Describe how to verify it
Verified locally with JDK 8:
- `./mvnw -B -pl sqlparser/seata-sqlparser-antlr -am clean package -DskipTests`: successful. Both ANTLR JARs contain Apache 2.0 plus the MIT grant and both upstream copyright notices; sqlparser-core is unaffected.
- `./mvnw -B -N -Psource-release assembly:single`: successful. Inspected the source tarball for the root LICENSE pointer and both new licensing resources.
- `./mvnw -B -f distribution/pom.xml -Prelease-seata antrun:run@aggregate-binary-license-and-notice`: successful. Checked the generated root LICENSE and the existing binary assembly selectors: normalize.css license goes to the root and namingserver, not server.
- Apache 2.0 terms, all existing NOTICE files, and LICENSE-server are unchanged; `git diff --check` passed.
The full binary distribution and signed RC were not rebuilt. Unit tests were skipped.
### Ⅴ. Special notes for reviews
Base: `2.7.0` at `2da6c236fa297ecf05184938354ffd707fa29fd4`. Rebuild and re-sign the affected RC artifacts and Maven staging artifacts after merging; this PR does not change published artifacts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve bundled MIT licenses in 2.7.0 release artifacts [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8308:
URL: https://github.com/apache/incubator-seata/pull/8308#issuecomment-6245870113
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8308?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 72.79%. Comparing base ([`2da6c23`](https://app.codecov.io/gh/apache/incubator-seata/commit/2da6c236fa297ecf05184938354ffd707fa29fd4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`c846095`](https://app.codecov.io/gh/apache/incubator-seata/commit/c8460950c8680c344e06d95bf806c5319bdc3cac?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.7.0 #8308 +/- ##
============================================
+ Coverage 72.69% 72.79% +0.09%
Complexity 883 883
============================================
Files 1327 1327
Lines 50769 50769
Branches 6058 6058
============================================
+ Hits 36906 36955 +49
+ Misses 10854 10801 -53
- Partials 3009 3013 +4
```
[see 12 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8308/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8308?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] fix: preserve bundled MIT licenses in 2.7.0 release artifacts [incubator-seata]
Posted by "Bughue (via GitHub)" <gi...@apache.org>.
Bughue merged PR #8308:
URL: https://github.com/apache/incubator-seata/pull/8308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org