You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Chris Foote <fo...@yahoo.com> on 2003/01/09 16:25:07 UTC
[PATCH] Fix typo in mailer.py
Hi,
This patch fixs a problem with the mailer.py hook script that I
found while playing with Gregs new changes.
Regards,
Chris
Log:
* mailer.py:
(ChangeCollector.change_dir_prop): Fix typo in key to changes
dictionary.
Index: tools/hook-scripts/mailer.py
===================================================================
--- tools/hook-scripts/mailer.py (revision 4305)
+++ tools/hook-scripts/mailer.py (working copy)
@@ -236,13 +236,13 @@
self.changes[dir_path].prop_changes = True
else:
# can't be added or deleted, so this must be CHANGED
- self.changes[dir_baton] = _change(ChangeCollector.DIR,
- True,
- dir_baton[1], # base_path
- dir_baton[2], # base_rev
- dir_path, # path
- False, # added
- )
+ self.changes[dir_path] = _change(ChangeCollector.DIR,
+ True,
+ dir_baton[1], # base_path
+ dir_baton[2], # base_rev
+ dir_path, # path
+ False, # added
+ )
def add_file(self, path, parent_baton,
copyfrom_path, copyfrom_revision, file_pool):
__________________________________________________
Do You Yahoo!?
Everything you'll ever need on one web page
from News and Sport to Email and Music Charts
http://uk.my.yahoo.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix typo in mailer.py
Posted by Matt Kraai <kr...@alumni.cmu.edu>.
On Thu, Jan 09, 2003 at 04:25:07PM +0000, Chris Foote wrote:
> This patch fixs a problem with the mailer.py hook script that I
> found while playing with Gregs new changes.
Thanks, fixed in revision 4307.
Matt
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix typo in mailer.py
Posted by Blair Zajac <bl...@orcaware.com>.
Greg Stein wrote:
>
> On Thu, Jan 09, 2003 at 06:10:21PM -0800, Blair Zajac wrote:
> > Greg Stein wrote:
> >...
> > > If there are specific features that you'd like to see, then I'd love to hear
> > > about it.
> >
> > My only request is to add in the .conf file or in mailer.py itself a
> > flag to use svnlook diff's --no-diff-deleted flag.
>
> mailer.py doesn't use svnlook :-)
>
> That said, I can easily skip a diff generation for deleted (and added)
> files.
I do want to see a diff between an empty file and an added file, just
not the deleted file.
> I've noted your request in the todo list (in my wc). Thanks!
Great. Thanks.
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix typo in mailer.py
Posted by Greg Stein <gs...@lyra.org>.
On Thu, Jan 09, 2003 at 06:10:21PM -0800, Blair Zajac wrote:
> Greg Stein wrote:
>...
> > If there are specific features that you'd like to see, then I'd love to hear
> > about it.
>
> My only request is to add in the .conf file or in mailer.py itself a
> flag to use svnlook diff's --no-diff-deleted flag.
mailer.py doesn't use svnlook :-)
That said, I can easily skip a diff generation for deleted (and added)
files. See the generate_diff() function. Line 107 is the start of the block
to deal with diff'ing deleted files. It can simply check the configuration
and punt if it has been disabled.
I've noted your request in the todo list (in my wc). Thanks!
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix typo in mailer.py
Posted by Blair Zajac <bl...@orcaware.com>.
Greg Stein wrote:
>
> * pipe output into a mail program (and avoid os.popen)
> * add configuration options
> - default options
> - per-group overrides
> - group selection based on repos and on path
> - each group defines:
> o how to construct From:
> o how to construct To:
> o whether to set Reply-To and/or Mail-Followup-To
> (btw: it is legal do set Reply-To since this is the originator of the
> mail; i.e. different from MLMs that munge it)
> o max size of diff before trimming
> o how to construct a ViewCVS URL for the diff
> o optional, non-mail log file
>
> If there are specific features that you'd like to see, then I'd love to hear
> about it.
My only request is to add in the .conf file or in mailer.py itself a
flag to use svnlook diff's --no-diff-deleted flag.
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Plots of your system's performance - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Fix typo in mailer.py
Posted by Greg Stein <gs...@lyra.org>.
On Thu, Jan 09, 2003 at 04:25:07PM +0000, Chris Foote wrote:
> Hi,
>
> This patch fixs a problem with the mailer.py hook script that I
> found while playing with Gregs new changes.
Thanks! I see that Matt already applied this.
As I mentioned somewhere, my next set of steps are:
* pipe output into a mail program (and avoid os.popen)
* add configuration options
- default options
- per-group overrides
- group selection based on repos and on path
- each group defines:
o how to construct From:
o how to construct To:
o whether to set Reply-To and/or Mail-Followup-To
(btw: it is legal do set Reply-To since this is the originator of the
mail; i.e. different from MLMs that munge it)
o max size of diff before trimming
o how to construct a ViewCVS URL for the diff
o optional, non-mail log file
If there are specific features that you'd like to see, then I'd love to hear
about it. My primary reasons to write the mailer.py (vs commit-email.pl) was
that I wanted a .conf file rather than a billion cmdline switches, and I
wanted to stream the output rather than load-into-mem-write-to-mailer like
commit-email does. I also prefer the bindings over forking, and there is
that whole Python vs Perl thing going on :-)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org