You are viewing a plain text version of this content. The canonical link for it is here.
Posted to j-dev@xerces.apache.org by "Joe Baysdon (JIRA)" <xe...@xml.apache.org> on 2010/02/23 18:56:28 UTC

[jira] Created: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
--------------------------------------------------------------------------------------------

                 Key: XERCESJ-1423
                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
             Project: Xerces2-J
          Issue Type: Bug
    Affects Versions: 2.9.1
         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
            Reporter: Joe Baysdon


The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.

The solution is to this line:
   e.prev = null;
to the rehash method, following this line:
   e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Updated: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Anli Shundi (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anli Shundi updated XERCESJ-1423:
---------------------------------

    Attachment: XERCESJ-1423.patch

patch

> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Commented: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Anli Shundi (JIRA)" <xe...@xml.apache.org>.
    [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840197#action_12840197 ] 

Anli Shundi commented on XERCESJ-1423:
--------------------------------------

TIBCO's already existing signed CLA on file; however:

7.3 If the contribution in question is a small bugfix, the contributor need not sign a CLA, but need only provide the following information, attaching it to the communication containing the patch:

a) Name and employer
Anli Shundi TIBCO Software

b) Are you the author of the code being contributed?
Yes

c) Do you have the right to grant the copyright and patent licenses for the contribution that are set forth in the ASF v.2.0 license (http://www.apache.org/licenses/LICENSE-2.0)?
YES

d) Does your employer have any rights to code that you have written, for example, through your contract for employment? If so, has your employer given you permission to contribute the code on its behalf or waived its rights in the code?
YES

e) Are you aware of any third-party licenses or other restrictions (such as related patents or trademarks) that could apply to your contribution? If so, what are they?
NO

> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Commented: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
    [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840210#action_12840210 ] 

Michael Glavassevich commented on XERCESJ-1423:
-----------------------------------------------

Anil, the CCLA doesn't cover individual contributions though given how small the patch is answering the questions is good enough here. In general we ask for a signed ICLA [1] from everyone. Thanks.

[1] http://www.apache.org/licenses/icla.txt

> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Commented: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
    [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837639#action_12837639 ] 

Michael Glavassevich commented on XERCESJ-1423:
-----------------------------------------------

Joe / Anli, it appears that neither of you have a CLA on record [1] with the ASF. For most contributions to Xerces a Contributor License Agreement (CLA) [2] is required. Faxing a signed copy of this agreement to Apache will allow us to accept your code into the project. Anli, since you contributed the patch can you do this?

Thanks.

[1] http://people.apache.org/~jim/committers.html
[2] http://xerces.apache.org/charter.html#CONTRIBUTORS

> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Issue Comment Edited: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Anli Shundi (JIRA)" <xe...@xml.apache.org>.
    [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12840197#action_12840197 ] 

Anli Shundi edited comment on XERCESJ-1423 at 3/2/10 3:14 PM:
--------------------------------------------------------------

TIBCO has already existing signed a CCLA which should be on file (ex. Eric Johnson); however

7.3 If the contribution in question is a small bugfix, the contributor need not sign a CLA, but need only provide the following information, attaching it to the communication containing the patch:

a) Name and employer
Anli Shundi TIBCO Software

b) Are you the author of the code being contributed?
Yes

c) Do you have the right to grant the copyright and patent licenses for the contribution that are set forth in the ASF v.2.0 license (http://www.apache.org/licenses/LICENSE-2.0)?
YES

d) Does your employer have any rights to code that you have written, for example, through your contract for employment? If so, has your employer given you permission to contribute the code on its behalf or waived its rights in the code?
YES

e) Are you aware of any third-party licenses or other restrictions (such as related patents or trademarks) that could apply to your contribution? If so, what are they?
NO

      was (Author: ashundi):
    TIBCO's already existing signed CLA on file; however:

7.3 If the contribution in question is a small bugfix, the contributor need not sign a CLA, but need only provide the following information, attaching it to the communication containing the patch:

a) Name and employer
Anli Shundi TIBCO Software

b) Are you the author of the code being contributed?
Yes

c) Do you have the right to grant the copyright and patent licenses for the contribution that are set forth in the ASF v.2.0 license (http://www.apache.org/licenses/LICENSE-2.0)?
YES

d) Does your employer have any rights to code that you have written, for example, through your contract for employment? If so, has your employer given you permission to contribute the code on its behalf or waived its rights in the code?
YES

e) Are you aware of any third-party licenses or other restrictions (such as related patents or trademarks) that could apply to your contribution? If so, what are they?
NO
  
> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Updated: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Glavassevich updated XERCESJ-1423:
------------------------------------------

    Component/s: Other

> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>            Assignee: Michael Glavassevich
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Assigned: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Glavassevich reassigned XERCESJ-1423:
---------------------------------------------

    Assignee: Michael Glavassevich

> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>            Assignee: Michael Glavassevich
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org


[jira] Resolved: (XERCESJ-1423) SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.

Posted by "Michael Glavassevich (JIRA)" <xe...@xml.apache.org>.
     [ https://issues.apache.org/jira/browse/XERCESJ-1423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael Glavassevich resolved XERCESJ-1423.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.10.0

Anil, I've reviewed your patch and have committed it to SVN (see rev 924298). Thanks.

> SoftReferenceSymbolTable has infinite loop due to cyclical reference in SREntry linked list.
> --------------------------------------------------------------------------------------------
>
>                 Key: XERCESJ-1423
>                 URL: https://issues.apache.org/jira/browse/XERCESJ-1423
>             Project: Xerces2-J
>          Issue Type: Bug
>          Components: Other
>    Affects Versions: 2.9.1
>         Environment: Windows XP SP3, and Arch Linux (2.6.31-ARCH)
>            Reporter: Joe Baysdon
>            Assignee: Michael Glavassevich
>             Fix For: 2.10.0
>
>         Attachments: XERCESJ-1423.patch
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> The rehash( ) method, in org.apache.xerces.util.SoftReferenceSymbolTable, does not re-set the SREntry.prev pointer to null, so the final entry placed in each bucket may have an improper  "prev" value following the rehash( ).  Since the removeEntry method uses that "prev" pointer to reconnect the linked list around the removed link, the linked list can contain an illegal cycle.  These cycles may produce infinite loops in either of the addSymbol methods or in the rehash method, itself.
> The solution is to this line:
>    e.prev = null;
> to the rehash method, following this line:
>    e.next = newTable[index];

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: j-dev-unsubscribe@xerces.apache.org
For additional commands, e-mail: j-dev-help@xerces.apache.org