You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/01/30 07:30:07 UTC

[GitHub] XD-DENG edited a comment on issue #4612: [AIRFLOW-3785] Decommission airflow/contrib/auth/backends

XD-DENG edited a comment on issue #4612: [AIRFLOW-3785] Decommission airflow/contrib/auth/backends
URL: https://github.com/apache/airflow/pull/4612#issuecomment-458840589
 
 
   @ashb @feng-tao @seelmann , What's you guys' take on this? Shall we remove or refactor these code? 
   
   To me, only `airflow/contrib/auth/backends/password_auth.py` may be worth refactoring (if we decide not to remove it), since it can be used by the API. All `other contrib/auth/backends` modules should be removed as they don't integrate with FAB UI well, and LDAP/OAuth on FAB UI should be done by extending `SecurityManager` instead (@feng-tao please advise if you agree on this).
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services