[GitHub] [hudi] danny0405 commented on a diff in pull request #9365: [HUDI-6646] Add default lock provider for spark offline compaction an…

["danny0405 (via GitHub)" <gi...@apache.org>]

danny0405 commented on code in PR #9365:
URL: https://github.com/apache/hudi/pull/9365#discussion_r1284450589


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -578,6 +580,20 @@ public static HoodieTableMetaClient createMetaClient(
         .build();
   }
 
+  public static void addLockOptions(String basePath, TypedProperties props) {
+    if (!props.containsKey(HoodieLockConfig.LOCK_PROVIDER_CLASS_NAME.key())) {
+      HoodieLockConfig lockConfig = HoodieLockConfig.newBuilder()
+          .withLockProvider(FileSystemBasedLockProvider.class)
+          .withLockWaitTimeInMillis(2000L) // 2s

Review Comment:
   Probably, the first step is to support a default config option.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org