Re: [PR] minor: Add `slt` test for nullable window retract [datafusion]

["2010YOUY01 (via GitHub)" <gi...@apache.org>]

2010YOUY01 commented on code in PR #24025:
URL: https://github.com/apache/datafusion/pull/24025#discussion_r3697758147


##########
datafusion/sqllogictest/test_files/window.slt:
##########
@@ -6843,16 +6843,17 @@ DROP TABLE issue_20194_t1;
 statement ok
 DROP TABLE issue_20194_t2;
 
-# Sliding-window MIN/MAX over a frame whose non-NULL values have all been
-# retracted should yield NULL.
-query IIII
+# Sliding-window over a frame whose non-NULL values have all been retracted should yield NULL.
+query IIIIRR
 SELECT id, x,
        MIN(x) OVER (ORDER BY id ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) AS min_x,
-       MAX(x) OVER (ORDER BY id ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) AS max_x
+       MAX(x) OVER (ORDER BY id ROWS BETWEEN 1 PRECEDING AND CURRENT ROW) AS max_x,

Review Comment:
   This is a good catch.
   
   I think we should definitely test them after SQL support (window frame bound support expr-based frames like `col1 preceding and col2 following`)
   
   For now I think this is not very important, since `Accumulator` is not a public API, such path is unreachable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org