You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2020/09/20 15:02:39 UTC
[GitHub] [logging-log4j2] gengyuanzhe opened a new pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone
gengyuanzhe opened a new pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone
Posted by GitBox <gi...@apache.org>.
gengyuanzhe commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695823514
Ok, I am not particularly familiar with the whole PR process, so I asked a lot of questions. Anyway, thank you for your patient repl.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695821455
Nothing left for you as far as I can tell. We can see if anyone else wants to review before merging. I'm currently working on some build-related fixes/improvements before I merge this myself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz commented on pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone
Posted by GitBox <gi...@apache.org>.
jvz commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695821455
Nothing left for you as far as I can tell. We can see if anyone else wants to review before merging. I'm currently working on some build-related fixes/improvements before I merge this myself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone
Posted by GitBox <gi...@apache.org>.
gengyuanzhe commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695820947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] gengyuanzhe commented on pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone
Posted by GitBox <gi...@apache.org>.
gengyuanzhe commented on pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423#issuecomment-695820947
@jvz Thanks for reply. Is there anything else I need to do, or just wait for other members to review my code?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] jvz merged pull request #423: [LOG4J2-2889] HtmlLayout support datePattern and timezone
Posted by GitBox <gi...@apache.org>.
jvz merged pull request #423:
URL: https://github.com/apache/logging-log4j2/pull/423
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org