[GitHub] [nifi] greyp9 commented on pull request #5307: NIFI-8917: add profiles for excluding minifi, nifi-registry, nifi-too…

[GitBox <gi...@apache.org>]

greyp9 commented on pull request #5307:
URL: https://github.com/apache/nifi/pull/5307#issuecomment-954263083


   Hi @markobean.  Nifty idea to break things out in this way.  I like the idea of building only needed parts of the project for a given task, and I've also looked at this issue some.
   
   Have you thought about leveraging built-in Maven functionality to achieve a similar effect?  The [-pl] and [-am] command-line switches provide the ability to build a given module, as well as any declared module dependencies.
   
   `mvn clean install -pl :nifi-assembly -am`
   - [builds 432 modules; excludes anything not declared as a "nifi-assembly" dependency]
   
   `mvn clean install -pl :minifi-c2-assembly -am`
   - [builds 75 modules...]
   
   `mvn clean install -pl :nifi-registry-assembly -am`
   - [builds 43 modules...]
   
   `mvn clean install -pl :nifi-stateless-assembly -am`
   - [builds 55 modules...]
   
   `mvn clean install -pl :nifi-registry-toolkit-assembly -pl :nifi-toolkit-assembly -pl :minifi-toolkit-assembly -am`
   - [builds 90 modules...]
   
   There appears to be some module dependency duplication with the toolkits, it might make sense to nest each of these
   under the appropriate "*-assembly", or new meta-modules could be introduced to build everything associated with minifi, for example (meta-modules might also be a good home for the docker modules).
   
   Rather than changing the root POM, maybe this could be expressed by adding some documentation, perhaps a section
   in README.MD.  What do you think?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org