[GitHub] [cordova-ios] bpresles opened a new pull request #663: Fix #661: Removed all UIWebView code.

[GitBox <gi...@apache.org>]

bpresles opened a new pull request #663: Fix #661: Removed all UIWebView code.
URL: https://github.com/apache/cordova-ios/pull/663
 
 
   Removed all UIWebView related code.
   Replaced default engine by CDVWKWebViewEngine.
   
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   I've tested the pull request from https://github.com/apache/cordova-ios/pull/662, but the AppStore Connect still reported "ITMS-90809: Deprecated API Usage - Apple will stop accepting submissions of apps that use UIWebView APIs." with it (I tripled check that the WKWebViewOnly preference was correctly taken in account).
   
   Also I don't think that doing a half way solution at compile time, instead of removing the UIWebView code altogether, is a good solution.
   If the UIWebView is deprecated, than remove the code altogether as it'll be useless in the near future. People wanting to still use UIWebView can either use a UIWebView engine as a plugin or use older version of cordova-ios.
   
   <!-- If it fixes an open issue, please link to the issue here. -->
   https://github.com/apache/cordova-ios/issues/661
   
   
   
   ### Description
   Removed all UIWebView code and replaced default engine by CDVWKWebViewEngine from cordova-plugin-wkwebview-engine (making it useless now).
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org