You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/25 15:23:28 UTC

[GitHub] [incubator-tvm] tqchen edited a comment on issue #5092: [TIR][PASS] dtype rewrite for indexing variables

tqchen edited a comment on issue #5092: [TIR][PASS] dtype rewrite for indexing variables
URL: https://github.com/apache/incubator-tvm/pull/5092#issuecomment-603902373
 
 
   Some more comments, mainly wrt to clarity of the code, test coverage and efficiency concerns. Thanks for bringing in the PR. given that this is critical to a lot of the codebase, let us try to https://docs.tvm.ai/contribute/code_review.html#hold-the-highest-standard :) Let us work to polish it to the best state. Thanks @hzfan for good work so far

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services