[GitHub] [iceberg] nastra commented on a diff in pull request #7321: Build: Fix flaky checkstyle issue

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7321:
URL: https://github.com/apache/iceberg/pull/7321#discussion_r1163102594


##########
baseline.gradle:
##########
@@ -33,7 +33,11 @@ subprojects {
   // ready to enforce linting on.
   apply plugin: 'org.inferred.processors'
   if (!project.hasProperty('quick')) {
-    apply plugin: 'com.palantir.baseline-checkstyle'
+    // com.palantir.baseline:gradle-baseline-java:4.42.0 (the last version supporting Java 8) pulls
+    // in an old version of the checkstyle(9.1), which has this OutOfMemory bug https://github.com/checkstyle/checkstyle/issues/10934
+    // So, replace com.palantir.baseline-checkstyle plugin usage with gradle checkstyle plugin

Review Comment:
   `So, replace "com.palantir.baseline-checkstyle" with "checkstyle" 9.3 (the latest java 8 supported version) which contains a fix`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org