You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2010/05/25 14:08:24 UTC

svn commit: r948017 - in /ofbiz/trunk/applications/accounting/widget: AccountingTrees.xml GlobalGlAccountsScreens.xml

Author: jleroux
Date: Tue May 25 12:08:24 2010
New Revision: 948017

URL: http://svn.apache.org/viewvc?rev=948017&view=rev
Log:
A patch from Ankit Jain "Edit/Navigate Global GL Account - Found URL parameter [glAccountId] passed to secure (https) request-map with uri [updateGlAccount]" (https://issues.apache.org/jira/browse/OFBIZ-3316) - OFBIZ-3316

The error can be reproduced as following:

Steps:
1) Go to Accounting > Global GL Settings > Select any value(100000) from the list > in the "Edit GL Account" update the record > now in the "Navigate Accounts" section click on any node .

Then you will get the error .......

Modified:
    ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml
    ofbiz/trunk/applications/accounting/widget/GlobalGlAccountsScreens.xml

Modified: ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml?rev=948017&r1=948016&r2=948017&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml (original)
+++ ofbiz/trunk/applications/accounting/widget/AccountingTrees.xml Tue May 25 12:08:24 2010
@@ -20,7 +20,30 @@ under the License.
 
 <trees xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="http://ofbiz.apache.org/dtds/widget-tree.xsd">
-    <tree name="GlAccountTree" entity-name="GlAccount" root-node-name="node-root" default-render-style="expand-collapse" default-wrap-style="accountItem">
+    <tree name="GlAccountTree" entity-name="GlAccount" root-node-name="node-root" default-render-style="expand-collapse" default-wrap-style="accountItem" expand-collapse-request="GlAccountNavigate">
+        <node name="node-root" render-style="simple">
+            <sub-node node-name="node-body">
+                <entity-and entity-name="GlAccount">
+                    <field-map field-name="parentGlAccountId" from-field="null"/>
+                    <order-by field-name="glAccountId"/>
+                </entity-and>
+            </sub-node>
+        </node>
+        <node name="node-body">
+            <entity-one entity-name="GlAccount" value-field="glAccount"></entity-one>
+            <link target="GlAccountNavigate" text="${glAccountId} ${glAccount.accountName} ${postedBalance}">
+                <parameter param-name="glAccountId"/>
+                <parameter param-name="trail"/>
+            </link>
+            <sub-node node-name="node-body">
+                <entity-and entity-name="GlAccount">
+                    <field-map field-name="parentGlAccountId" from-field="glAccountId"/>
+                    <order-by field-name="glAccountId"/>
+                </entity-and>
+            </sub-node>
+        </node>
+    </tree>
+    <tree name="ListGlAccountTree" entity-name="GlAccount" root-node-name="node-root" default-render-style="expand-collapse" default-wrap-style="accountItem">
         <node name="node-root" render-style="simple">
             <sub-node node-name="node-body">
                 <entity-and entity-name="GlAccount">

Modified: ofbiz/trunk/applications/accounting/widget/GlobalGlAccountsScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/widget/GlobalGlAccountsScreens.xml?rev=948017&r1=948016&r2=948017&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/widget/GlobalGlAccountsScreens.xml (original)
+++ ofbiz/trunk/applications/accounting/widget/GlobalGlAccountsScreens.xml Tue May 25 12:08:24 2010
@@ -152,7 +152,7 @@ under the License.
                 <decorator-screen name="main-decorator" location="${parameters.mainDecoratorLocation}">
                     <decorator-section name="body">
                         <screenlet title="${uiLabelMap.PageTitleViewGlAccountEntries}">
-                            <include-tree name="GlAccountTree" location="component://accounting/widget/AccountingTrees.xml"/>
+                            <include-tree name="ListGlAccountTree" location="component://accounting/widget/AccountingTrees.xml"/>
                         </screenlet>
                         <screenlet title="${uiLabelMap.PageTitleViewGlAccountEntries}">
                             <include-form name="ListAcctgTransEntries" location="component://accounting/widget/GlobalGlAccountsForms.xml"/>
@@ -178,7 +178,7 @@ under the License.
                     <decorator-section name="body">
                         <include-menu name="GlAccountTabBar" location="component://accounting/widget/AccountingMenus.xml"/>
                         <screenlet title="${uiLabelMap.PageTitleViewAccountingTransaction}">
-                            <include-tree name="GlAccountTree" location="component://accounting/widget/AccountingTrees.xml"/>
+                            <include-tree name="ListGlAccountTree" location="component://accounting/widget/AccountingTrees.xml"/>
                         </screenlet>
                         <screenlet title="${uiLabelMap.PageTitleViewAccountingTransaction}">
                             <include-form name="ListAcctgTransEntries" location="component://accounting/widget/GlobalGlAccountsForms.xml"/>
@@ -207,7 +207,7 @@ under the License.
 
                         <!-- include-screen screen-name="ListGlAccounts" name="ListGlAccounts" / -->
 
-                        <!-- tree name="GlAccountTree" location="component://accounting/widget/AccountingTrees.xml"/ -->
+                        <!-- tree name="ListGlAccountTree" location="component://accounting/widget/AccountingTrees.xml"/ -->
                      </decorator-section>
                 </decorator-screen>
             </widgets>