You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "ayushtkn (via GitHub)" <gi...@apache.org> on 2023/05/11 07:26:38 UTC
[GitHub] [hive] ayushtkn opened a new pull request, #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
ayushtkn opened a new pull request, #4312:
URL: https://github.com/apache/hive/pull/4312
### What changes were proposed in this pull request?
Use correct reader when reading in case of write operation
### Why are the changes needed?
Data correctness.
### Does this PR introduce _any_ user-facing change?
Correct Results, after delete operation on iceberg table.
### How was this patch tested?
UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190929783
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
same thing is done here:
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
the same thing is done here:
````
HiveCustomStorageHandlerUtils.getWriteOperation(configuration, tableName)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190929783
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
the same thing is done here:
````
HiveCustomStorageHandlerUtils.getWriteOperation(configuration, tableName)
return DELETE == operation || UPDATE ==operation
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4312:
URL: https://github.com/apache/hive/pull/4312#issuecomment-1545026485
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4312)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4312&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4312&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1191499685
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -62,6 +63,8 @@ protected void analyze(ASTNode tree, Table table, ASTNode tabNameNode) throws Se
switch (tree.getToken().getType()) {
case HiveParser.TOK_DELETE_FROM:
operation = Context.Operation.DELETE;
+ HiveCustomStorageHandlerUtils.setFileScanOperationType(ctx.getConf(), table.getFullTableName().toString(),
Review Comment:
didn't catch this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn closed pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn closed pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
URL: https://github.com/apache/hive/pull/4312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1191474658
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
the conf used is different, that is used by FileSink, If I play with that the projectSchema will consume it and leads to different world.
So, created a different for FileScan.
https://github.com/apache/hive/blob/dd3fd775406c2d621c42ef1adce2fa0f3b9acd39/iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java#L160-L172
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190929783
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
is this they way we try to identify operation type, it looks not very straitforward
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
is this they way we try to identify operation type? it looks not very straightforward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1192208369
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
+ if (conf == null || tableName == null) {
+ return false;
+ }
+ String operation = conf.get(FILESCAN_WRITE_OPERATION_CONFIG_PREFIX + getTableName(tableName));
+ return Context.Operation.DELETE.name().equalsIgnoreCase(operation) ||
+ Context.Operation.UPDATE.name().equalsIgnoreCase(operation);
+ }
+
+ public static void setFileScanOperationType(Configuration conf, String tableName, Context.Operation operation) {
+ if (conf == null || tableName == null) {
+ return;
+ }
+ conf.set(
+ FILESCAN_WRITE_OPERATION_CONFIG_PREFIX + getTableName(tableName),
+ operation.name());
+ }
+
+ private static String getTableName(String tableName) {
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190926687
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
+ if (conf == null || tableName == null) {
+ return false;
+ }
+ String operation = conf.get(FILESCAN_WRITE_OPERATION_CONFIG_PREFIX + getTableName(tableName));
+ return Context.Operation.DELETE.name().equalsIgnoreCase(operation) ||
+ Context.Operation.UPDATE.name().equalsIgnoreCase(operation);
+ }
+
+ public static void setFileScanOperationType(Configuration conf, String tableName, Context.Operation operation) {
+ if (conf == null || tableName == null) {
+ return;
+ }
+ conf.set(
+ FILESCAN_WRITE_OPERATION_CONFIG_PREFIX + getTableName(tableName),
+ operation.name());
+ }
+
+ private static String getTableName(String tableName) {
Review Comment:
why do we need this? see how we pass it to `HiveIcebergInputFormat.getVectorizationConfName(tableName)` in orcRecordReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190929783
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
the same thing is done here:
````
org.apache.hadoop.hive.ql.security.authorization.HiveCustomStorageHandlerUtils.getWriteOperation(configuration, tableName)
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190928327
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -62,6 +63,8 @@ protected void analyze(ASTNode tree, Table table, ASTNode tabNameNode) throws Se
switch (tree.getToken().getType()) {
case HiveParser.TOK_DELETE_FROM:
operation = Context.Operation.DELETE;
+ HiveCustomStorageHandlerUtils.setFileScanOperationType(ctx.getConf(), table.getFullTableName().toString(),
Review Comment:
how about MergeSemanticAnalyzer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] deniskuzZ commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "deniskuzZ (via GitHub)" <gi...@apache.org>.
deniskuzZ commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1190926687
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
+ if (conf == null || tableName == null) {
+ return false;
+ }
+ String operation = conf.get(FILESCAN_WRITE_OPERATION_CONFIG_PREFIX + getTableName(tableName));
+ return Context.Operation.DELETE.name().equalsIgnoreCase(operation) ||
+ Context.Operation.UPDATE.name().equalsIgnoreCase(operation);
+ }
+
+ public static void setFileScanOperationType(Configuration conf, String tableName, Context.Operation operation) {
+ if (conf == null || tableName == null) {
+ return;
+ }
+ conf.set(
+ FILESCAN_WRITE_OPERATION_CONFIG_PREFIX + getTableName(tableName),
+ operation.name());
+ }
+
+ private static String getTableName(String tableName) {
Review Comment:
why do we need this? see how we pass it to `HiveIcebergInputFormat.getVectorizationConfName(tableName)` in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1191474658
##########
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/HiveCustomStorageHandlerUtils.java:
##########
@@ -71,4 +73,26 @@ public static void setWriteOperation(Configuration conf, String tableName, Conte
conf.set(WRITE_OPERATION_CONFIG_PREFIX + tableName, operation.name());
}
+
+ public static boolean isWriteOperation(Configuration conf, String tableName) {
Review Comment:
the conf used is different, that is used by FileSink, If I play with that the projectSchema will consume it and leads to different world.
So, created a different for FileScan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] ayushtkn commented on a diff in pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "ayushtkn (via GitHub)" <gi...@apache.org>.
ayushtkn commented on code in PR #4312:
URL: https://github.com/apache/hive/pull/4312#discussion_r1192208177
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java:
##########
@@ -62,6 +63,8 @@ protected void analyze(ASTNode tree, Table table, ASTNode tabNameNode) throws Se
switch (tree.getToken().getType()) {
case HiveParser.TOK_DELETE_FROM:
operation = Context.Operation.DELETE;
+ HiveCustomStorageHandlerUtils.setFileScanOperationType(ctx.getConf(), table.getFullTableName().toString(),
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4312:
URL: https://github.com/apache/hive/pull/4312#issuecomment-1545778081
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4312)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL) [19 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4312&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4312&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4312: HIVE-27331: Iceberg: Rows are not deleted from table when execution mode is vectorized llap.
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4312:
URL: https://github.com/apache/hive/pull/4312#issuecomment-1546748275
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4312)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4312&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4312&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4312&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4312&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org