You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/03/19 06:09:39 UTC
[jira] [Commented] (THRIFT-3047) Uneven calls to indent_up and
indent_down in Cocoa generator
[ https://issues.apache.org/jira/browse/THRIFT-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14368527#comment-14368527 ]
ASF GitHub Bot commented on THRIFT-3047:
----------------------------------------
GitHub user yelirekim opened a pull request:
https://github.com/apache/thrift/pull/401
THRIFT-3047: Fixing indentation for generated cocoa sources
indent_down was called one extra time when generating the client which gave us an indentation level of -1, then to combat this, we indented the server implementation an extra level. This appeared as if everything was fine unless you generated more than one service in a thrift file, in which case the indentation would get progressively worse.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yelirekim/thrift feature/cocoa-indentation
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/401.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #401
----
commit 6e02061253d3d0a1342fc9d67914bc991258b209
Author: Mike Riley <mi...@yelirekim.com>
Date: 2015-03-19T04:58:31Z
Fixing indentation for generated cocoa sources
----
> Uneven calls to indent_up and indent_down in Cocoa generator
> ------------------------------------------------------------
>
> Key: THRIFT-3047
> URL: https://issues.apache.org/jira/browse/THRIFT-3047
> Project: Thrift
> Issue Type: Bug
> Components: Cocoa - Compiler
> Reporter: Mike Riley
> Priority: Minor
> Fix For: 0.9.3
>
>
> indent_down was called one extra time which gave us an indentation level of -1, then to combat this, we indented the server implementation an extra level. This appeared as if everything was fine unless you generated two services in one thrift file, in which case the indentation would get progressively worse.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)