You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/05/05 18:24:22 UTC
zeppelin git commit: [ZEPPELIN-2479] Fix incorrect tooltip view
inside of version control menu
Repository: zeppelin
Updated Branches:
refs/heads/master ae05740b1 -> 8e96d8bd7
[ZEPPELIN-2479] Fix incorrect tooltip view inside of version control menu
### What is this PR for?
This is to fix incorrect appearance of tooltip inside version control menu
### What type of PR is it?
Improvement
### Todos
* [x] - fix/remove tooltip
### What is the Jira issue?
[ZEPPELIN-2479](https://issues.apache.org/jira/browse/ZEPPELIN-2479)
### How should this be tested?
go to `version control` menu in notebook action bar of note
### Screenshots (if appropriate)
before:
<img width="689" alt="screen shot 2017-05-02 at 3 32 23 pm" src="https://cloud.githubusercontent.com/assets/1642088/25606467/62f0901c-2f4c-11e7-95ef-c22f1df410be.png">
after:
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Khalid Huseynov <kh...@gmail.com>
Closes #2306 from khalidhuseynov/fix/ZEPPELIN-2479 and squashes the following commits:
ac4e651 [Khalid Huseynov] add css class
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/8e96d8bd
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/8e96d8bd
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/8e96d8bd
Branch: refs/heads/master
Commit: 8e96d8bd7b6e1a01df004800c526d316725a2b62
Parents: ae05740
Author: Khalid Huseynov <kh...@gmail.com>
Authored: Tue May 2 18:45:11 2017 +0900
Committer: Lee moon soo <mo...@apache.org>
Committed: Fri May 5 14:24:17 2017 -0400
----------------------------------------------------------------------
zeppelin-web/src/app/notebook/notebook-actionBar.html | 2 ++
zeppelin-web/src/app/notebook/notebook.css | 6 ++++--
2 files changed, 6 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8e96d8bd/zeppelin-web/src/app/notebook/notebook-actionBar.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook-actionBar.html b/zeppelin-web/src/app/notebook/notebook-actionBar.html
index 00434c9..10368c8 100644
--- a/zeppelin-web/src/app/notebook/notebook-actionBar.html
+++ b/zeppelin-web/src/app/notebook/notebook-actionBar.html
@@ -131,6 +131,8 @@ limitations under the License.
ng-hide="viewOnly"
ng-click="checkpointNote(note.checkpoint.message)"
style="margin-left: 4px;"
+ tooltip-append-to-body="true"
+ tooltip-class="revisionTooltip"
tooltip-placement="bottom" uib-tooltip="Commit this note">Commit
</button>
</div>
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/8e96d8bd/zeppelin-web/src/app/notebook/notebook.css
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/notebook.css b/zeppelin-web/src/app/notebook/notebook.css
index 86a2dd2..1bd0080 100644
--- a/zeppelin-web/src/app/notebook/notebook.css
+++ b/zeppelin-web/src/app/notebook/notebook.css
@@ -51,6 +51,10 @@
border-color: #ccc;
}
+.revisionTooltip {
+ z-index: 10003;
+}
+
.caretSeparator {
height: 22px;
line-height: 9px;
@@ -313,7 +317,6 @@
max-width: 50%;
}
-
.inactivelink {
color: darkgrey;
cursor: default;
@@ -330,4 +333,3 @@
}
.noteAction.headroom--unpinned { top: -100px; }
.noteAction.headroom--pinned { top: 50px; /** `noteAction` top */ }
-