You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Saksham Srivastava <sa...@citrix.com> on 2013/08/19 13:10:22 UTC

Review Request 13644: CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13644/
-----------------------------------------------------------

Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.


Bugs: CLOUDSTACK-4257


Repository: cloudstack-git


Description
-------

Test case integration.component.test_storage_motion.TestStorageMotion.test_02_migrate_volume failed during api call liststorage pool with unexpected result 
AssertionError: Check list storage pools response for valid list

This happens when there are no suitable pools found for migration.
Added check for empty pool list and then skip the test if no suitable hosts are found.


Diffs
-----

  test/integration/component/test_storage_motion.py eda77d1 

Diff: https://reviews.apache.org/r/13644/diff/


Testing
-------

If there is a single pool in the cluster, the test is skipped.
If multiple suitable hosts are found, the test passes.


Thanks,

Saksham Srivastava


Re: Review Request 13644: CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13644/#review25343
-----------------------------------------------------------


Commit ed745d3489340eb0394264a379a22a10c76092b9 in branch refs/heads/master from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=ed745d3 ]

CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit a9e45bf7766728c8439fcc0e3a1a6e3af074b2b7)


- ASF Subversion and Git Services


On Aug. 19, 2013, 11:10 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13644/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 11:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case integration.component.test_storage_motion.TestStorageMotion.test_02_migrate_volume failed during api call liststorage pool with unexpected result 
> AssertionError: Check list storage pools response for valid list
> 
> This happens when there are no suitable pools found for migration.
> Added check for empty pool list and then skip the test if no suitable hosts are found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_storage_motion.py eda77d1 
> 
> Diff: https://reviews.apache.org/r/13644/diff/
> 
> 
> Testing
> -------
> 
> If there is a single pool in the cluster, the test is skipped.
> If multiple suitable hosts are found, the test passes.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13644: CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13644/#review25342
-----------------------------------------------------------


Commit 9ed5083f9bd9eb668ea152635c98e1598c38f7c2 in branch refs/heads/master from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9ed5083 ]

CLOUDSTACK-4257: Additional asserts for storage migration test

Test whether valid storage pools are listed and at least one pool is
available for migration.

Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit a82f66e0fa8c9e20b0468aae82871c46a9f8b67e)


- ASF Subversion and Git Services


On Aug. 19, 2013, 11:10 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13644/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 11:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case integration.component.test_storage_motion.TestStorageMotion.test_02_migrate_volume failed during api call liststorage pool with unexpected result 
> AssertionError: Check list storage pools response for valid list
> 
> This happens when there are no suitable pools found for migration.
> Added check for empty pool list and then skip the test if no suitable hosts are found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_storage_motion.py eda77d1 
> 
> Diff: https://reviews.apache.org/r/13644/diff/
> 
> 
> Testing
> -------
> 
> If there is a single pool in the cluster, the test is skipped.
> If multiple suitable hosts are found, the test passes.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13644: CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13644/#review25345
-----------------------------------------------------------


Commit a9e45bf7766728c8439fcc0e3a1a6e3af074b2b7 in branch refs/heads/4.2 from Saksham Srivastava
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a9e45bf ]

CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On Aug. 19, 2013, 11:10 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13644/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 11:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case integration.component.test_storage_motion.TestStorageMotion.test_02_migrate_volume failed during api call liststorage pool with unexpected result 
> AssertionError: Check list storage pools response for valid list
> 
> This happens when there are no suitable pools found for migration.
> Added check for empty pool list and then skip the test if no suitable hosts are found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_storage_motion.py eda77d1 
> 
> Diff: https://reviews.apache.org/r/13644/diff/
> 
> 
> Testing
> -------
> 
> If there is a single pool in the cluster, the test is skipped.
> If multiple suitable hosts are found, the test passes.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13644: CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13644/#review25344
-----------------------------------------------------------


Commit a82f66e0fa8c9e20b0468aae82871c46a9f8b67e in branch refs/heads/4.2 from Prasanna Santhanam
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a82f66e ]

CLOUDSTACK-4257: Additional asserts for storage migration test

Test whether valid storage pools are listed and at least one pool is
available for migration.

Signed-off-by: Prasanna Santhanam <ts...@apache.org>


- ASF Subversion and Git Services


On Aug. 19, 2013, 11:10 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13644/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 11:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case integration.component.test_storage_motion.TestStorageMotion.test_02_migrate_volume failed during api call liststorage pool with unexpected result 
> AssertionError: Check list storage pools response for valid list
> 
> This happens when there are no suitable pools found for migration.
> Added check for empty pool list and then skip the test if no suitable hosts are found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_storage_motion.py eda77d1 
> 
> Diff: https://reviews.apache.org/r/13644/diff/
> 
> 
> Testing
> -------
> 
> If there is a single pool in the cluster, the test is skipped.
> If multiple suitable hosts are found, the test passes.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>


Re: Review Request 13644: CLOUDSTACK-4257: [Automation] test_storage_motion test cases failed during with unexpected result in listStoragePool API call

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13644/#review25346
-----------------------------------------------------------

Ship it!


Applied with additional asserts

- Prasanna Santhanam


On Aug. 19, 2013, 11:10 a.m., Saksham Srivastava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13644/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2013, 11:10 a.m.)
> 
> 
> Review request for cloudstack, Devdeep Singh and Prasanna Santhanam.
> 
> 
> Bugs: CLOUDSTACK-4257
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Test case integration.component.test_storage_motion.TestStorageMotion.test_02_migrate_volume failed during api call liststorage pool with unexpected result 
> AssertionError: Check list storage pools response for valid list
> 
> This happens when there are no suitable pools found for migration.
> Added check for empty pool list and then skip the test if no suitable hosts are found.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_storage_motion.py eda77d1 
> 
> Diff: https://reviews.apache.org/r/13644/diff/
> 
> 
> Testing
> -------
> 
> If there is a single pool in the cluster, the test is skipped.
> If multiple suitable hosts are found, the test passes.
> 
> 
> Thanks,
> 
> Saksham Srivastava
> 
>