[GitHub] [flink-connector-jdbc] wanglijie95 commented on pull request #2: [FLINK-28284] Add JdbcSink with new format

[GitBox <gi...@apache.org>]

wanglijie95 commented on PR #2:
URL: https://github.com/apache/flink-connector-jdbc/pull/2#issuecomment-1359578023

   @MartijnVisser @eskabetxe Yes, I think it(expose ExecutionConfig or isObjectReuseEnabled) is a blocker to the migration. The jdbc sink needs to decide whether to buffer the copies or the original records based on object-reuse. (When the object reuse is enabled, we should buffer the copies(because the content of the objects may be changed before flush), otherwise we should buffer the original record).
   
   @eskabetxe It would be great if you are willing to drive the FLIP(expose ExecutionConfig or isObjectReuseEnabled) and discussion (I'm currently too busy with other 1.17 features to do this). Otherwise, I will start this FLIP after the 1.17 code freeze, which means this change needs to be put into the next version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org