You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/05 10:26:10 UTC

[GitHub] [flink] aljoscha opened a new pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

aljoscha opened a new pull request #14559:
URL: https://github.com/apache/flink/pull/14559


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

zentol commented on a change in pull request #14559:
URL: https://github.com/apache/flink/pull/14559#discussion_r551844811



##########
File path: docs/flinkDev/ide_setup.md
##########
@@ -106,6 +106,7 @@ formatting on saving with these steps:
 5. Install the [Save Actions
    plugin](https://plugins.jetbrains.com/plugin/7642-save-actions)
 6. Enable the plugin, along with "Optimize imports" and "Reformat file"
+7. Make sure to configure "Save Actions" to only run on Java files. Otherwise you will get unintended reformatting in other files you edit.

Review comment:
       ```suggestion
   7. In the "Save Actions"settings page, setup a "File Path Inclusion" for `.*\.java` to only run on Java files. Otherwise you will get unintended reformatting in other files you edit.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14559:
URL: https://github.com/apache/flink/pull/14559#issuecomment-754553061


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d15ec725d3efa062d8520d5afbbd92c212062b9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2d15ec725d3efa062d8520d5afbbd92c212062b9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d15ec725d3efa062d8520d5afbbd92c212062b9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

zentol commented on a change in pull request #14559:
URL: https://github.com/apache/flink/pull/14559#discussion_r551844811



##########
File path: docs/flinkDev/ide_setup.md
##########
@@ -106,6 +106,7 @@ formatting on saving with these steps:
 5. Install the [Save Actions
    plugin](https://plugins.jetbrains.com/plugin/7642-save-actions)
 6. Enable the plugin, along with "Optimize imports" and "Reformat file"
+7. Make sure to configure "Save Actions" to only run on Java files. Otherwise you will get unintended reformatting in other files you edit.

Review comment:
       ```suggestion
   7. In the "Save Actions" settings page, setup a "File Path Inclusion" for `.*\.java`. Otherwise you will get unintended reformatting in other files you edit.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14559:
URL: https://github.com/apache/flink/pull/14559#issuecomment-754553061


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2d15ec725d3efa062d8520d5afbbd92c212062b9",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11648",
       "triggerID" : "2d15ec725d3efa062d8520d5afbbd92c212062b9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2d15ec725d3efa062d8520d5afbbd92c212062b9 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11648) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha commented on pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

aljoscha commented on pull request #14559:
URL: https://github.com/apache/flink/pull/14559#issuecomment-754648810


   Thanks for the review and the suggestion!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] aljoscha closed pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

aljoscha closed pull request #14559:
URL: https://github.com/apache/flink/pull/14559


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

flinkbot edited a comment on pull request #14559:
URL: https://github.com/apache/flink/pull/14559#issuecomment-754549406

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit fa22660319e5ab75b115c028466242c724722880 (Fri May 28 07:00:48 UTC 2021)

**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.

Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:

- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a change in pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

zentol commented on a change in pull request #14559:
URL: https://github.com/apache/flink/pull/14559#discussion_r551844811



##########
File path: docs/flinkDev/ide_setup.md
##########
@@ -106,6 +106,7 @@ formatting on saving with these steps:
 5. Install the [Save Actions
    plugin](https://plugins.jetbrains.com/plugin/7642-save-actions)
 6. Enable the plugin, along with "Optimize imports" and "Reformat file"
+7. Make sure to configure "Save Actions" to only run on Java files. Otherwise you will get unintended reformatting in other files you edit.

Review comment:
       ```suggestion
   7. In the "Save Actions" settings page, setup a "File Path Inclusion" for `.*\.java` to only run on Java files. Otherwise you will get unintended reformatting in other files you edit.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14559: [minor] Update IDE setup guide, to apply Save Actions only to Java files

Posted by GitBox <gi...@apache.org>.

flinkbot commented on pull request #14559:
URL: https://github.com/apache/flink/pull/14559#issuecomment-754549406

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

## Automated Checks
Last check on commit 2d15ec725d3efa062d8520d5afbbd92c212062b9 (Tue Jan 05 10:27:55 UTC 2021)

**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
* **Invalid pull request title: No valid Jira ID provided**

<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org