[GitHub] [airflow] potiuk commented on a diff in pull request #33124: Move openlineage configuration to provider

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk commented on code in PR #33124:
URL: https://github.com/apache/airflow/pull/33124#discussion_r1284727429


##########
airflow/providers/openlineage/plugins/openlineage.py:
##########
@@ -25,7 +25,7 @@
 
 def _is_disabled() -> bool:
     return (
-        conf.getboolean("openlineage", "disabled")
+        conf.getboolean("openlineage", "disabled", fallback=False)

Review Comment:
   @mobuchowski - I had to add explicit fallback here as our "import" check checks the case where the providers are imported directly - and Provider's Manager might not yet have been initialized with provider configurations. So all top-level imports of configuration have to have explicit fallback, despite it being also specified in the provider.yaml
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org