[GitHub] mistercrunch closed pull request #5612: [sql lab] always use NullPool

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5612: [sql lab] always use NullPool
URL: https://github.com/apache/incubator-superset/pull/5612
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/sql_lab.py b/superset/sql_lab.py
index b97761d3ca..a659653d37 100644
--- a/superset/sql_lab.py
+++ b/superset/sql_lab.py
@@ -165,7 +165,7 @@ def handle_error(msg):
     try:
         engine = database.get_sqla_engine(
             schema=query.schema,
-            nullpool=not ctask.request.called_directly,
+            nullpool=True,
             user_name=user_name,
         )
         conn = engine.raw_connection()


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org