[GitHub] [cordova-ios] raphinesse commented on pull request #1180: refactor!: drop platform binaries

[GitBox <gi...@apache.org>]

raphinesse commented on pull request #1180:
URL: https://github.com/apache/cordova-ios/pull/1180#issuecomment-961732482


   > Other binaries & scripts that will need reviewing... Maybe another PR?
   > ...
   > I believe some of these could be removed and/or merged into some JS file(s) and exported.
   
   The following bins are used outside of `cordova-ios` and should be left alone for now:
   ```
   apple_ios_version
   ./lib/src/plugman/util/default-engines.js
   43:            { platform: 'ios', scriptSrc: path.join(project_dir, 'cordova', 'apple_ios_version') },
   
   apple_osx_version
   ./lib/src/plugman/util/default-engines.js
   45:            { platform: 'ios', scriptSrc: path.join(project_dir, 'cordova', 'apple_osx_version') },
   
   apple_xcode_version
   ./lib/src/plugman/util/default-engines.js
   41:            { platform: 'ios', scriptSrc: path.join(project_dir, 'cordova', 'apple_xcode_version') },
   
   list-devices
   ./lib/src/cordova/targets.js
   35:    const caller = { script: 'list-devices' };
   37:    const cmd = path.join(projectRoot, 'platforms', platform, 'cordova', 'lib', 'list-devices');
   
   list-emulator-images
   ./lib/src/cordova/targets.js
   42:    const caller = { script: 'list-emulator-images' };
   44:    const cmd = path.join(projectRoot, 'platforms', platform, 'cordova', 'lib', 'list-emulator-images');
   ```
   These are not used outside of cordova-ios and could be removed in this PR:
   
   - cordova_plist_to_config_xml
   - list-emulator-build-targets
   - list-started-emulators
   - start-emulator


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org