You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by zhan849 <gi...@git.apache.org> on 2018/03/08 22:13:34 UTC

[GitHub] helix pull request #140: [HELIX-679] consolidate semantics of recursively de...

GitHub user zhan849 opened a pull request:

    https://github.com/apache/helix/pull/140

    [HELIX-679] consolidate semantics of recursively delete path in ZkClient

    This change consolidates semantics of APIs in ZkClient that recursively deletes a path
    
    * For backward compatibility, we keep `deleteRecursive()`, which will only return true/false, and will not throw exception.
    * create a new method called deleteRecursively() that will only throw exception upon error.
    * mark `deleteRecursive()` as deprecated as throwing exception can carry error information
    * make all current usage of `deleteRecursive()` to `deleteRecursively()` 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhan849/helix harry/zk-client-fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/140.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #140
    
----
commit 8412d3f7e7d8097eee820c4d055b1526ac74aca1
Author: hrzhang <hr...@...>
Date:   2018-03-08T22:04:42Z

    [HELIX-679] consolidate semantics of recursively delete path in ZkClient

----


---

[GitHub] helix pull request #140: [HELIX-679] consolidate semantics of recursively de...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/140


---