[GitHub] [libcloud] Kami commented on a change in pull request #1357: adding a sync/async flag for destroy_node

[GitBox <gi...@apache.org>]

Kami commented on a change in pull request #1357: adding a sync/async flag for destroy_node
URL: https://github.com/apache/libcloud/pull/1357#discussion_r334250603
 
 

 ##########
 File path: libcloud/compute/drivers/gce.py
 ##########
 @@ -6816,7 +6831,7 @@ def ex_destroy_autoscaler(self, autoscaler):
         self.connection.async_request(request, method='DELETE')
         return True
 
-    def destroy_node(self, node, destroy_boot_disk=False):
+    def destroy_node(self, node, destroy_boot_disk=False, sync=True):
 
 Review comment:
   I will go ahead and rename this to ``ex_sync`` since this is a "standard" API method so non-standard arguments should be prefixed with ``ex_`` (there is no ``ex_`` prefix needed with methods which already contain ``ex_`` prefix itself).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services