[GitHub] flink pull request: FLINK-3579 Improve String concatenation (Ram)

[ramkrish86 <gi...@git.apache.org>]

Github user ramkrish86 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1821#discussion_r58191031
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ExpressionParser.scala ---
    @@ -59,6 +59,8 @@ object ExpressionParser extends JavaTokenParsers with PackratParsers {
               Literal(str.toInt)
             } else if (str.endsWith("f") | str.endsWith("F")) {
               Literal(str.toFloat)
    +        } else if (str.endsWith(".")) {
    --- End diff --
    
    @tillrohrmann 
    This '.' related change I think I need more time to understand how this parser works. So for this PR can i only handle the string concat part. I have ensured that 42+a+b or a + b + 42 works fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---