You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@subversion.apache.org by Julien Dufour <ju...@inferiis.com> on 2004/03/29 11:34:16 UTC

Suggestions regarding "svn-commit.tmp" management

Hello there

When a commit operation fails, subversion fortunately saves the message 
provided using the editor in the "svn-commit.tmp" file. However, this 
file seems to be completely ignored later. What about the following 
suggestions?

- When a "svn-commit.tmp" file exists, its content should be 
automatically inserted in the interactive editor instead of the usual 
empty message. I think that should improve user experience when trying 
to commit again after fixing the error which occurred during the first 
commit attempt.

- When successfully committing some change, the possibly existing 
"svn-commit.tmp" file should be automatically deleted. It would avoid 
doing it by hand or getting "? svn-commit.tmp" in the status report.

Those behaviors of course apply to every operation which requires a 
message.

What do you think?

Best regards.

Julien Dufour
Inferiis - http://www.inferiis.com


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org

Re: Suggestions regarding "svn-commit.tmp" management

Posted by Vincent Lefevre <vi...@vinc17.org>.
On 2004-03-29 13:34:16 +0200, Julien Dufour wrote:
> - When a "svn-commit.tmp" file exists, its content should be 
> automatically inserted in the interactive editor instead of the usual 
> empty message. I think that should improve user experience when trying 
> to commit again after fixing the error which occurred during the first 
> commit attempt.

Agreed, though currently, I can easily insert it with Emacs (this
could even be done automatically).

> - When successfully committing some change, the possibly existing 
> "svn-commit.tmp" file should be automatically deleted. It would avoid 
> doing it by hand or getting "? svn-commit.tmp" in the status report.

I disagree as there would be a possible loss of information (perhaps
in rare cases, but still annoying). I would say that it should be
deleted if this is the same log message as the one that was committed.

-- 
Vincent Lefèvre <vi...@vinc17.org> - Web: <http://www.vinc17.org/> - 100%
validated (X)HTML - Acorn Risc PC, Yellow Pig 17, Championnat International
des Jeux Mathématiques et Logiques, TETRHEX, etc.
Work: CR INRIA - computer arithmetic / SPACES project at LORIA

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@subversion.tigris.org
For additional commands, e-mail: users-help@subversion.tigris.org