You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/07/25 14:49:35 UTC

[GitHub] [inlong] fuweng11 opened a new pull request, #5202: [INLONG-5201][Manager] Find entities in the database before updating inlong group

fuweng11 opened a new pull request, #5202:
URL: https://github.com/apache/inlong/pull/5202

   
   ### Prepare a Pull Request
   
   - Fixes #5201 
   
   ### Motivation
   
   After successful approval, the inlong group and inlong stream can be updated normally.
   
   
   ### Modifications
   
   1、Find entities in the database before updating inlong group.
   2、Ensure that each update operation is verified for the success of the update.
   
   ### Verifying this change
   
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.
   
   - [X] This change is already covered by existing tests, such as:
     *(please describe tests)*
   
   - [ ] This change added tests and can be verified as follows:
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5202: [INLONG-5201][Manager] Find entities in the database before updating inlong group

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5202:
URL: https://github.com/apache/inlong/pull/5202#discussion_r928984471


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/listener/apply/AfterApprovedTaskListener.java:
##########
@@ -74,7 +74,7 @@ public ListenerResult listen(WorkflowContext context) throws WorkflowListenerExc
         }
 
         // save the inlong group and other info after approval
-        groupService.updateAfterApprove(approveInfo, context.getOperator());
+        groupService.updateAfterApprove(approveInfo, context.getOperator(), entity);

Review Comment:
   Suggest moving the check and entity into the `updateAfterApprove ` method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #5202: [INLONG-5201][Manager] Find entities in the database before updating inlong group

Posted by GitBox <gi...@apache.org>.
healchow merged PR #5202:
URL: https://github.com/apache/inlong/pull/5202


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org