[GitHub] [openoffice] ardovm commented on pull request #133: graphite: remove the -Werror option from debug builds

[GitBox <gi...@apache.org>]

ardovm commented on pull request #133:
URL: https://github.com/apache/openoffice/pull/133#issuecomment-864605285


   The first two warnings are IMHO bugs. The first one is a function parameter type `bool` instead of `bool&` and the second is a mixup of return values in a `switch` statement.
   
   Others are linked to assertions not being compiled (although we are requesting a debug build). Some others are unused variables that are explicitly marked `TODO` in the code.
   
   I stopped after checking the first four warnings.
   
   I suggest we allow this PR through so that at least the source becomes compilable again. Then we could have a longer term plan for the replacement of the graphite with... whatever is better today.
   
   For what it's worth, both the [SourceForge project page](http://silgraphite.sourceforge.net) and [www.sil.org](https://software.sil.org/products/#supported) refer to http://graphite.sil.org that does not seem to exist.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org