You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@tajo.apache.org by charsyam <gi...@git.apache.org> on 2014/11/22 19:12:45 UTC

[GitHub] tajo pull request: TAJO-1207: Remove redundant code in Bytes.java ...

GitHub user charsyam opened a pull request:

    https://github.com/apache/tajo/pull/267

    TAJO-1207: Remove redundant code in Bytes.java in tajo-common

    in Bytes.java
    padHead and padTail
    Don't need to set array to 0.
    because java alloc byte array and initialize them as 0.
    ```java
    byte [] padding = new byte[length];
    //so below is redundant block
    for (int i = 0; i < length; i++)
    { padding[i] = 0; }
    return add(padding,a);
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/charsyam/tajo feature/remove_code

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #267
    
----
commit de6edbd2a0d39476582a0dc35c4a7b941d9d0300
Author: clark.kang <cl...@kakao.com>
Date:   2014-11-22T18:07:02Z

    remove unnessary code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1207: Remove redundant code in Bytes.java ...

Posted by hyunsik <gi...@git.apache.org>.

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/267#issuecomment-68172507
  
    Hi @charsyam,
    
    We borrowed Bytes.java from HBase for (de) serialization compatibility, and we sometimes updated the class. So, we don't need to improve this class. Anyway, thank you for your finding and your contribution!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1207: Remove redundant code in Bytes.java ...

Posted by charsyam <gi...@git.apache.org>.

Github user charsyam closed the pull request at:

    https://github.com/apache/tajo/pull/267


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1207: Remove redundant code in Bytes.java ...

Posted by hyunsik <gi...@git.apache.org>.

Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/267#issuecomment-68172519
  
    Could you close this github ticket?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---